From 30adad5ae6568b5ef1125f206989d447fb999eee Mon Sep 17 00:00:00 2001 From: WofWca Date: Tue, 28 Mar 2023 10:21:19 +0000 Subject: [PATCH] feat: mark undone if task moved from isDoneBucket (#3291) Addresses #545 (not completely) Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/3291 Reviewed-by: Dominik Pschenitschni Reviewed-by: konrad Co-authored-by: WofWca Co-committed-by: WofWca --- src/views/project/ProjectKanban.vue | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/views/project/ProjectKanban.vue b/src/views/project/ProjectKanban.vue index 4d8233594..ff15e11f2 100644 --- a/src/views/project/ProjectKanban.vue +++ b/src/views/project/ProjectKanban.vue @@ -415,6 +415,7 @@ async function updateTaskPosition(e) { : e.newIndex const task = newBucket.tasks[newTaskIndex] + const oldBucket = buckets.value.find(b => b.id === task.bucketId) const taskBefore = newBucket.tasks[newTaskIndex - 1] ?? null const taskAfter = newBucket.tasks[newTaskIndex + 1] ?? null taskUpdating.value[task.id] = true @@ -425,6 +426,13 @@ async function updateTaskPosition(e) { taskBefore !== null ? taskBefore.kanbanPosition : null, taskAfter !== null ? taskAfter.kanbanPosition : null, ) + if ( + oldBucket != undefined && // This shouldn't actually be `undefined`, but let's play it safe. + newBucket.id !== oldBucket.id && + newBucket.isDoneBucket !== oldBucket.isDoneBucket + ) { + newTask.done = newBucket.isDoneBucket + } try { await taskStore.update(newTask)