From 551f3f54e19c0ff6bf13d2a8248b54ea0d04bfa4 Mon Sep 17 00:00:00 2001
From: Dominik Pschenitschni <mail@celement.de>
Date: Thu, 23 Jun 2022 03:28:48 +0200
Subject: [PATCH] chore: better variable typing

---
 src/components/notifications/notifications.vue | 2 +-
 src/components/sharing/linkSharing.vue         | 2 +-
 src/components/tasks/partials/comments.vue     | 4 ++--
 src/components/tasks/partials/description.vue  | 1 +
 src/components/tasks/partials/listSearch.vue   | 2 +-
 src/components/tasks/partials/repeatAfter.vue  | 5 +++--
 src/views/list/NewList.vue                     | 2 +-
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/components/notifications/notifications.vue b/src/components/notifications/notifications.vue
index 62d23a72d..bb788a11b 100644
--- a/src/components/notifications/notifications.vue
+++ b/src/components/notifications/notifications.vue
@@ -63,7 +63,7 @@ const LOAD_NOTIFICATIONS_INTERVAL = 10000
 const store = useStore()
 const router = useRouter()
 
-const allNotifications = ref([])
+const allNotifications = ref<NotificationModel[]>([])
 const showNotifications = ref(false)
 const popup = ref(null)
 
diff --git a/src/components/sharing/linkSharing.vue b/src/components/sharing/linkSharing.vue
index b38a58341..4cdf873fb 100644
--- a/src/components/sharing/linkSharing.vue
+++ b/src/components/sharing/linkSharing.vue
@@ -198,7 +198,7 @@ const props = defineProps({
 
 const {t} = useI18n({useScope: 'global'})
 
-const linkShares = ref([])
+const linkShares = ref<LinkShareModel[]>([])
 const linkShareService = shallowReactive(new LinkShareService())
 const selectedRight = ref(RIGHTS.READ)
 const name = ref('')
diff --git a/src/components/tasks/partials/comments.vue b/src/components/tasks/partials/comments.vue
index 3501eadcd..48b7b6bd0 100644
--- a/src/components/tasks/partials/comments.vue
+++ b/src/components/tasks/partials/comments.vue
@@ -188,8 +188,8 @@ const commentEdit = reactive(new TaskCommentModel())
 
 const newComment = reactive(new TaskCommentModel())
 
-const saved = ref(null)
-const saving = ref(null)
+const saved = ref<TaskModel['id'] | null>(null)
+const saving = ref<TaskModel['id'] | null>(null)
 
 const userAvatar = computed(() => store.state.auth.info.getAvatarUrl(48))
 const currentUserId = computed(() => store.state.auth.info.id)
diff --git a/src/components/tasks/partials/description.vue b/src/components/tasks/partials/description.vue
index 2b3a14cea..71b1f37a3 100644
--- a/src/components/tasks/partials/description.vue
+++ b/src/components/tasks/partials/description.vue
@@ -47,6 +47,7 @@ const props = defineProps({
 		required: true,
 	},
 	canWrite: {
+		type: Boolean,
 		required: true,
 	},
 })
diff --git a/src/components/tasks/partials/listSearch.vue b/src/components/tasks/partials/listSearch.vue
index 482e47e2e..58c156439 100644
--- a/src/components/tasks/partials/listSearch.vue
+++ b/src/components/tasks/partials/listSearch.vue
@@ -38,7 +38,7 @@ const emit = defineEmits(['update:modelValue'])
 const store = useStore()
 const {t} = useI18n({useScope: 'global'})
 
-const list = reactive<ListModel>(new ListModel())
+const list: ListModel= reactive(new ListModel())
 
 watch(
 	() => props.modelValue,
diff --git a/src/components/tasks/partials/repeatAfter.vue b/src/components/tasks/partials/repeatAfter.vue
index a4fa76cb0..81b4f1962 100644
--- a/src/components/tasks/partials/repeatAfter.vue
+++ b/src/components/tasks/partials/repeatAfter.vue
@@ -55,12 +55,13 @@
 </template>
 
 <script setup lang="ts">
-import {ref, reactive, watch} from 'vue'
-import TaskModel from '@/models/task'
+import {ref, reactive, watch, type PropType} from 'vue'
 import {TASK_REPEAT_MODES, type RepeatAfter} from '@/models/task'
+import type TaskModel from '@/models/task'
 
 const props = defineProps({
 	modelValue: {
+		type: Object as PropType<TaskModel>,
 		default: () => ({}),
 		required: true,
 	},
diff --git a/src/views/list/NewList.vue b/src/views/list/NewList.vue
index a63dc4081..28ec71d49 100644
--- a/src/views/list/NewList.vue
+++ b/src/views/list/NewList.vue
@@ -63,7 +63,7 @@ async function createNewList() {
 	}
 	showError.value = false
 
-	list.namespaceId = parseInt(route.params.namespaceId)
+	list.namespaceId = Number(route.params.namespaceId as string)
 	const newList = await store.dispatch('lists/createList', list)
 	await router.push({
 		name: 'list.index',