From a01fc161fa1c643233dee2aebcccc656c1598163 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Sat, 24 Oct 2020 17:38:54 +0200
Subject: [PATCH] Remove "collapse menu button" and make the hamburger button
 always visible

---
 src/App.vue                      | 13 +++----------
 src/styles/theme/navigation.scss | 26 ++++++++------------------
 2 files changed, 11 insertions(+), 28 deletions(-)

diff --git a/src/App.vue b/src/App.vue
index 5fb763ea4..a692c09bb 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -15,9 +15,10 @@
 						<img alt="Vikunja" src="/images/logo-full.svg" v-else/>
 					</router-link>
 					<a
-						:class="{'is-visible': !menuActive}"
-						@click="menuActive = true"
+						@click="menuActive = !menuActive"
 						class="menu-show-button"
+						@shortkey="() => menuActive = !menuActive"
+						v-shortkey="['ctrl', 'e']"
 					>
 						<icon icon="bars"></icon>
 					</a>
@@ -149,14 +150,6 @@
 							</ul>
 						</div>
 
-						<a
-							@click="menuActive = false"
-							@shortkey="() => menuActive = !menuActive"
-							class="collapse-menu-button"
-							v-shortkey="['ctrl', 'e']">
-							Collapse Menu
-						</a>
-
 						<aside class="menu namespaces-lists">
 							<template v-for="n in namespaces">
 								<div :key="n.id">
diff --git a/src/styles/theme/navigation.scss b/src/styles/theme/navigation.scss
index bc29bb82c..640b8930e 100644
--- a/src/styles/theme/navigation.scss
+++ b/src/styles/theme/navigation.scss
@@ -132,20 +132,6 @@
       left: 0;
     }
 
-    .collapse-menu-button {
-      font-size: .75rem;
-      color: $grey;
-      text-align: center;
-      display: block;
-      width: 100%;
-      margin: $navbar-padding / 2 0 $navbar-padding;
-      cursor: pointer;
-
-      @media screen and (max-width: $tablet) {
-        display: none;
-      }
-    }
-
     .menu {
       .menu-label {
         font-size: 1em;
@@ -307,6 +293,10 @@
           display: block;
         }
       }
+
+      &.namespaces-lists {
+        padding-top: $navbar-padding / 2;
+      }
     }
 
     .top-menu {
@@ -387,6 +377,10 @@
   }
 }
 
+.navbar-brand .menu-show-button {
+  display: block;
+}
+
 .mobile-overlay {
   display: none;
   position: fixed;
@@ -422,10 +416,6 @@
   }
 }
 
-.menu-show-button.is-visible {
-  display: block;
-}
-
 .logout-icon {
   margin-right: 0.85em !important;
 }