From 51c806c12b90aa124384497856590f5010b9ff49 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 7 Sep 2022 17:57:44 +0200
Subject: [PATCH 1/5] feat: color the task color button when the task has a
 color set

---
 src/views/tasks/TaskDetailView.vue | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index a584aeb63..2c5b573b8 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -379,6 +379,8 @@
 							variant="secondary"
 							icon="fill-drip"
 							v-shortcut="'c'"
+							:class="{'has-light-text': color !== TASK_DEFAULT_COLOR && !colorIsDark(color)}"
+							:style="{'background-color': color !== TASK_DEFAULT_COLOR ? color : false}"
 						>
 							{{ $t('task.detail.actions.color') }}
 						</x-button>
@@ -429,7 +431,7 @@ import {defineComponent} from 'vue'
 import cloneDeep from 'lodash.clonedeep'
 
 import TaskService from '../../services/task'
-import TaskModel from '@/models/task'
+import TaskModel, {TASK_DEFAULT_COLOR} from '@/models/task'
 import type {ITask} from '@/modelTypes/ITask'
 
 import { PRIORITIES as priorites } from '@/constants/priorities'
@@ -461,6 +463,7 @@ import { setTitle } from '@/helpers/setTitle'
 import {getNamespaceTitle} from '@/helpers/getNamespaceTitle'
 import {getListTitle} from '@/helpers/getListTitle'
 import type { IList } from '@/modelTypes/IList'
+import {colorIsDark} from '@/helpers/color/colorIsDark'
 
 function scrollIntoView(el) {
 	if (!el) {
@@ -527,6 +530,8 @@ export default defineComponent({
 			showDeleteModal: false,
 			// Used to avoid flashing of empty elements if the task content is not yet loaded.
 			visible: false,
+			
+			TASK_DEFAULT_COLOR,
 
 			activeFields: {
 				assignees: false,
@@ -594,6 +599,11 @@ export default defineComponent({
 		shouldShowClosePopup() {
 			return this.$route.name.includes('kanban')
 		},
+		color() {
+			return this.task.getHexColor
+				? this.task.getHexColor()
+				: TASK_DEFAULT_COLOR
+		},
 	},
 	methods: {
 		getNamespaceTitle,
@@ -745,6 +755,8 @@ export default defineComponent({
 			this.task = await this.taskService.update(this.task)
 			this.$store.dispatch('namespaces/loadNamespacesIfFavoritesDontExist')
 		},
+		
+		colorIsDark,
 	},
 })
 </script>
@@ -932,7 +944,11 @@ $flash-background-duration: 750ms;
     .button {
       width: 100%;
       margin-bottom: .5rem;
-      justify-content: left;
+      justify-content: left; 
+
+      &.has-light-text {
+		color: var(--white);
+      }
     }
   }
 

From bdf992c9bfe9de176a22f7b5a6fdae1bc5e5010f Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 14 Sep 2022 18:56:51 +0200
Subject: [PATCH 2/5] feat: color the color button icon instead of the button
 itself

---
 src/components/input/button.vue    | 15 +++++++++++++--
 src/views/tasks/TaskDetailView.vue | 11 +++++++----
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/src/components/input/button.vue b/src/components/input/button.vue
index 0131c287b..ae34391dc 100644
--- a/src/components/input/button.vue
+++ b/src/components/input/button.vue
@@ -9,9 +9,16 @@
 			}
 		]"
 	>
-		<icon :icon="icon" v-if="showIconOnly"/>
+		<icon 
+			v-if="showIconOnly"
+			:icon="icon"
+			:style="{'color': iconColor !== '' ? iconColor : false}"
+		/>
 		<span class="icon is-small" v-else-if="icon !== ''">
-			<icon :icon="icon"/>
+			<icon 
+				:icon="icon"
+				:style="{'color': iconColor !== '' ? iconColor : false}"
+			/>
 		</span>
 		<slot />
 	</BaseButton>
@@ -42,6 +49,10 @@ const props = defineProps({
 		type: [String, Array],
 		default: '',
 	},
+	iconColor: {
+		type: String,
+		default: '',
+	},
 	loading: {
 		type: Boolean,
 		default: false,
diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index 2c5b573b8..b75e73257 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -378,9 +378,8 @@
 							@click="setFieldActive('color')"
 							variant="secondary"
 							icon="fill-drip"
+							:icon-color="color"
 							v-shortcut="'c'"
-							:class="{'has-light-text': color !== TASK_DEFAULT_COLOR && !colorIsDark(color)}"
-							:style="{'background-color': color !== TASK_DEFAULT_COLOR ? color : false}"
 						>
 							{{ $t('task.detail.actions.color') }}
 						</x-button>
@@ -600,9 +599,13 @@ export default defineComponent({
 			return this.$route.name.includes('kanban')
 		},
 		color() {
-			return this.task.getHexColor
+			const color = this.task.getHexColor
 				? this.task.getHexColor()
-				: TASK_DEFAULT_COLOR
+				: false
+			
+			return color === TASK_DEFAULT_COLOR
+				? ''
+				: color
 		},
 	},
 	methods: {

From 2683fec0a67f6afd16579bb44a6ceadc0edd565f Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 15 Sep 2022 13:56:14 +0200
Subject: [PATCH 3/5] feat: show the task color bubble everywhere

---
 src/components/home/navigation.vue            | 17 ++++++------
 src/components/misc/colorBubble.vue           | 26 +++++++++++++++++++
 src/components/tasks/partials/heading.vue     | 21 +++++++++++----
 .../tasks/partials/singleTaskInList.vue       | 24 +++++++++--------
 4 files changed, 64 insertions(+), 24 deletions(-)
 create mode 100644 src/components/misc/colorBubble.vue

diff --git a/src/components/home/navigation.vue b/src/components/home/navigation.vue
index dc09c5d72..07be48e08 100644
--- a/src/components/home/navigation.vue
+++ b/src/components/home/navigation.vue
@@ -56,10 +56,10 @@
 						class="menu-label"
 						v-tooltip="namespaceTitles[nk]"
 					>
-						<span
+						<ColorBubble
 							v-if="n.hexColor !== ''"
-							:style="{ backgroundColor: n.hexColor }"
-							class="color-bubble"
+							:color="n.hexColor"
+							class="mr-1"
 						/>
 						<span class="name">{{ namespaceTitles[nk] }}</span>
 						<div
@@ -114,11 +114,11 @@
 									<span class="icon handle">
 										<icon icon="grip-lines"/>
 									</span>
-									<span
-										:style="{ backgroundColor: l.hexColor }"
-										class="color-bubble"
-										v-if="l.hexColor !== ''">
-									</span>
+									<ColorBubble
+											v-if="l.hexColor !== ''"
+										:color="l.hexColor"
+										class="mr-1"
+									/>
 									<span class="list-menu-title">{{ getListTitle(l) }}</span>
 								</BaseButton>
 								<BaseButton
@@ -158,6 +158,7 @@ import {getListTitle} from '@/helpers/getListTitle'
 import {useEventListener} from '@vueuse/core'
 import type {IList} from '@/modelTypes/IList'
 import type {INamespace} from '@/modelTypes/INamespace'
+import ColorBubble from '@/components/misc/colorBubble.vue'
 
 const drag = ref(false)
 const dragOptions = {
diff --git a/src/components/misc/colorBubble.vue b/src/components/misc/colorBubble.vue
new file mode 100644
index 000000000..19fe3de83
--- /dev/null
+++ b/src/components/misc/colorBubble.vue
@@ -0,0 +1,26 @@
+<template>
+	<span
+		:style="{backgroundColor: color }"
+		class="color-bubble"
+	></span>
+</template>
+
+<script lang="ts" setup>
+defineProps({
+	color: {
+		type: String,
+		required: true,
+	},
+})
+</script>
+
+<style scoped>
+.color-bubble {
+	display: inline-block;
+	border-radius: 100%;
+	margin-right: 4px;
+	height: 10px;
+	width: 10px;
+	flex-shrink: 0;
+}
+</style>
\ No newline at end of file
diff --git a/src/components/tasks/partials/heading.vue b/src/components/tasks/partials/heading.vue
index 9b57c2ad6..b8bc51cf6 100644
--- a/src/components/tasks/partials/heading.vue
+++ b/src/components/tasks/partials/heading.vue
@@ -1,7 +1,12 @@
 <template>
 	<div class="heading">
 		<BaseButton @click="copyUrl"><h1 class="title task-id">{{ textIdentifier }}</h1></BaseButton>
-		<Done class="heading__done" :is-done="task.done" />
+		<Done class="heading__done" :is-done="task.done"/>
+		<ColorBubble
+			v-if="task.hexColor !== ''"
+			:color="task.getHexColor()"
+			class="mt-1 ml-2"
+		/>
 		<h1
 			class="title input"
 			:class="{'disabled': !canWrite}"
@@ -42,6 +47,7 @@ import Done from '@/components/misc/Done.vue'
 import {useCopyToClipboard} from '@/composables/useCopyToClipboard'
 
 import type {ITask} from '@/modelTypes/ITask'
+import ColorBubble from '@/components/misc/colorBubble.vue'
 
 const props = defineProps({
 	task: {
@@ -58,10 +64,11 @@ const emit = defineEmits(['update:task'])
 
 const router = useRouter()
 const copy = useCopyToClipboard()
+
 async function copyUrl() {
-	const route = router.resolve({ name: 'task.detail', query: { taskId: props.task.id}})
+	const route = router.resolve({name: 'task.detail', query: {taskId: props.task.id}})
 	const absoluteURL = new URL(route.href, window.location.href).href
-	
+
 	await copy(absoluteURL)
 }
 
@@ -95,8 +102,7 @@ async function save(title: string) {
 		setTimeout(() => {
 			showSavedMessage.value = false
 		}, 2000)
-	}
-	finally {
+	} finally {
 		saving.value = false
 	}
 }
@@ -106,4 +112,9 @@ async function save(title: string) {
 .heading__done {
 	margin-left: .5rem;
 }
+
+.color-bubble {
+	height: .75rem;
+	width: .75rem;
+}
 </style>
\ No newline at end of file
diff --git a/src/components/tasks/partials/singleTaskInList.vue b/src/components/tasks/partials/singleTaskInList.vue
index 2794de163..6fef7fa77 100644
--- a/src/components/tasks/partials/singleTaskInList.vue
+++ b/src/components/tasks/partials/singleTaskInList.vue
@@ -1,12 +1,11 @@
 <template>
 	<div :class="{'is-loading': taskService.loading}" class="task loader-container">
 		<fancycheckbox :disabled="(isArchived || disabled) && !canMarkAsDone" @change="markAsDone" v-model="task.done"/>
-		<span
+		<ColorBubble
 			v-if="showListColor && listColor !== ''"
-			:style="{backgroundColor: listColor }"
-			class="color-bubble"
-		>
-		</span>
+			:color="listColor"
+			class="mr-1"
+		/>
 		<router-link
 			:to="taskDetailRoute"
 			:class="{ 'done': task.done}"
@@ -15,11 +14,17 @@
 				<router-link
 					:to="{ name: 'list.list', params: { listId: task.listId } }"
 					class="task-list"
+					:class="{'mr-2': task.hexColor !== ''}"
 					v-if="showList && $store.getters['lists/getListById'](task.listId) !== null"
 					v-tooltip="$t('task.detail.belongsToList', {list: $store.getters['lists/getListById'](task.listId).title})">
 					{{ $store.getters['lists/getListById'](task.listId).title }}
 				</router-link>
 
+				<ColorBubble
+					v-if="task.hexColor !== ''"
+					:color="task.getHexColor()"
+					class="mr-1"
+				/>
 				<!-- Show any parent tasks to make it clear this task is a sub task of something -->
 				<span class="parent-tasks" v-if="typeof task.relatedTasks.parenttask !== 'undefined'">
 					<template v-for="(pt, i) in task.relatedTasks.parenttask">
@@ -30,7 +35,7 @@
 				{{ task.title }}
 			</span>
 
-			<labels class="labels ml-2 mr-1" :labels="task.labels" v-if="task.labels.length > 0" />
+			<labels class="labels ml-2 mr-1" :labels="task.labels" v-if="task.labels.length > 0"/>
 			<user
 				:avatar-size="27"
 				:is-inline="true"
@@ -111,6 +116,7 @@ import {closeWhenClickedOutside} from '@/helpers/closeWhenClickedOutside'
 import {playPop} from '@/helpers/playPop'
 import ChecklistSummary from './checklist-summary.vue'
 import {formatDateSince, formatISO, formatDateLong} from '@/helpers/time/formatDate'
+import ColorBubble from '@/components/misc/colorBubble.vue'
 
 export default defineComponent({
 	name: 'singleTaskInList',
@@ -122,6 +128,7 @@ export default defineComponent({
 		}
 	},
 	components: {
+		ColorBubble,
 		BaseButton,
 		ChecklistSummary,
 		DeferTask,
@@ -282,11 +289,6 @@ export default defineComponent({
 		white-space: nowrap;
 	}
 
-	.color-bubble {
-		height: 10px;
-		flex: 0 0 10px;
-	}
-
 	.avatar {
 		border-radius: 50%;
 		vertical-align: bottom;

From 6d9c4a7aa083425e252b96729b57c16ab13fd295 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 15 Sep 2022 14:32:29 +0200
Subject: [PATCH 4/5] chore: improve types

---
 src/components/misc/colorBubble.vue | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/components/misc/colorBubble.vue b/src/components/misc/colorBubble.vue
index 19fe3de83..523cf2aac 100644
--- a/src/components/misc/colorBubble.vue
+++ b/src/components/misc/colorBubble.vue
@@ -6,12 +6,11 @@
 </template>
 
 <script lang="ts" setup>
-defineProps({
-	color: {
-		type: String,
-		required: true,
-	},
-})
+import type { Color } from 'csstype'
+
+defineProps< {
+	color: Color,
+}>()
 </script>
 
 <style scoped>

From 4fce71f729878d47c3ec79d0c10fae8fbaabbd91 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 15 Sep 2022 14:37:07 +0200
Subject: [PATCH 5/5] fix: remove margin from the color bubble component itself

---
 src/components/misc/colorBubble.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/components/misc/colorBubble.vue b/src/components/misc/colorBubble.vue
index 523cf2aac..1b1f037d0 100644
--- a/src/components/misc/colorBubble.vue
+++ b/src/components/misc/colorBubble.vue
@@ -17,7 +17,6 @@ defineProps< {
 .color-bubble {
 	display: inline-block;
 	border-radius: 100%;
-	margin-right: 4px;
 	height: 10px;
 	width: 10px;
 	flex-shrink: 0;