page freezes when editing a comment with bullets #1871

New Issue

Ghost · 2021-11-22T12:08:57Z

Ghost commented

2021-11-22 12:08:57 +00:00

This can be reproduced (in Firefox) by creating a comment like this:

- here is
- my multiline
- bulleted list

saving, and then clicking edit and trying to add another line:

- here is
- my multiline
- bulleted list
- check it out

Sometimes a few characters can be typed before it freezes. Firefox then displays the option to stop the page due to the tab slowing down Firefox.

This can be reproduced (**in Firefox**) by creating a comment like this: ```markdown - here is - my multiline - bulleted list ``` saving, and then clicking edit and trying to add another line: ```markdown - here is - my multiline - bulleted list - check it out ``` Sometimes a few characters can be typed before it freezes. Firefox then displays the option to stop the page due to the tab slowing down Firefox.

dpschen added the

kind/bug

label 2021-11-22 13:17:28 +00:00

konrad commented

2021-11-22 19:08:58 +00:00

Can you reproduce this on try? I wasn't able to reproduce.

It is likely this is related to the version of Firefox used as well as the OS + specs of it. Could you provide those details as well?

Can you reproduce this on [try](https://try.vikunja.io)? I wasn't able to reproduce. It is likely this is related to the version of Firefox used as well as the OS + specs of it. Could you provide those details as well?

Ghost commented

2021-11-22 20:05:48 +00:00

Yes this was reproduced on try about 20 hours ago.

$ firefox --version
Mozilla Firefox 94.0.2
$ uname -a
Linux <device_name> 5.15.2-2-MANJARO #1 SMP PREEMPT Sat Nov 13 19:25:38 UTC 2021 x86_64 GNU/Linux

Yes this was reproduced on try about 20 hours ago. ```txt $ firefox --version Mozilla Firefox 94.0.2 $ uname -a Linux <device_name> 5.15.2-2-MANJARO #1 SMP PREEMPT Sat Nov 13 19:25:38 UTC 2021 x86_64 GNU/Linux ```

konrad commented

2021-11-22 20:41:03 +00:00

Is it reproducable every time you try it with the steps above? As mentioned, I couldn't reproduce it.

Ghost commented

2021-11-22 22:03:38 +00:00

Yes, I'm getting this every single time I try this. I'm logged into the demo account on try and you can see the comment I'm attempting to edit here

Yes, I'm getting this every single time I try this. I'm logged into the demo account on try and you can see the comment I'm attempting to edit [here](https://try.vikunja.io/tasks/20)

Ghost commented

2021-11-22 22:04:45 +00:00

It freezes whether I edit by pasting a replacement text or by pressing enter to add a new line.

konrad commented

2021-11-23 07:07:06 +00:00

@kylrth is this what you're seeing? https://community.vikunja.io/t/lists-but-not-lists-of-tasks/225/15

Ghost commented

2021-11-23 11:17:07 +00:00

Yes in fact, I get that in the console

keeper commented

2021-11-23 16:38:11 +00:00

In Firefox Dev
TypeError: can't access property "getAvatarUrl", t.author is undefined

In 0.18.1 it works fine.
Possibly related to this: vikunja/frontend#832

In Firefox Dev TypeError: can't access property "getAvatarUrl", t.author is undefined In 0.18.1 it works fine. Possibly related to this: https://kolaente.dev/vikunja/frontend/pulls/832

konrad referenced this issue from a commit

2021-11-23 18:21:50 +00:00

fix: edit task comment

konrad closed this issue

2021-11-23 18:21:50 +00:00

konrad commented

2021-11-23 18:22:46 +00:00

Resolved in dc347ed8ba - please check on try or with the latest unstable build once released in ~30min.

Resolved in https://kolaente.dev/vikunja/frontend/commit/dc347ed8ba4fa0a0299981f46820662c0be2b976 - please check on [try](https://try.vikunja.io) or with the latest unstable build once released in ~30min.

keeper commented

2021-11-23 18:30:52 +00:00

Works. Thanks!

Ghost commented

2021-11-23 18:37:30 +00:00

@keeper you're seeing it working on try already? It's still broken for me, even with a hard refresh.

keeper commented

2021-11-23 18:43:37 +00:00

@keeper you're seeing it working on try already? It's still broken for me, even with a hard refresh.

On https://try.vikunja.io/ doesn't work yet. I build from source.

> @keeper you're seeing it working on try already? It's still broken for me, even with a hard refresh. On https://try.vikunja.io/ doesn't work yet. I build from source.

konrad referenced this issue from a commit

2024-02-07 14:00:33 +00:00

fix(deps): update sentry-javascript monorepo to v6.19.7 (#1871)

Sign in to join this conversation.