Dark mode fixes #1875

New Issue

konrad · 2021-11-22T21:11:25Z

konrad commented

2021-11-22 21:11:25 +00:00

I've noticed three more things:

The selected command in the quick actions menu should use a different color:

Links should have the primary color by default. You can see this here ("Edit" is a link):

The borders in the table view should use a darker color:

Originally posted by @konrad in vikunja/frontend#954 (comment)

I've noticed three more things: 1. The selected command in the quick actions menu should use a different color: ![image](/attachments/2826745a-ec3f-4641-ba47-67bd2cfc174e) 2. Links should have the primary color by default. You can see this here ("Edit" is a link): ![image](/attachments/7ed776b3-fd4b-4b46-b6da-f947abc5e646) 3. The borders in the table view should use a darker color: ![image](/attachments/a3d9f990-b1eb-415d-af40-3be7c4420943) _Originally posted by @konrad in https://kolaente.dev/vikunja/frontend/pulls/954#issuecomment-20008_

konrad referenced this issue from vikunja/frontend

2021-11-22 21:11:55 +00:00

Migrate to bulma-css-variables and introduce dark mode #954

dpschen added the

kind/bug

label 2021-11-23 10:46:10 +00:00

dpschen commented

2021-11-23 12:43:04 +00:00

Adding this here since this might be related to the variable changes:

The color $dark seems to be different than var(--dark).

I realized this after adjusting the styles for the tooltip.
The tooltips have a different grey tone now (see screenshots).

Adding this here since this might be related to the variable changes: The color `$dark` seems to be different than `var(--dark)`. I realized this after adjusting the styles for the tooltip. The tooltips have a different grey tone now (see screenshots).

Screenshot 2021-11-22 at 22.30.10.png

15 KiB

Screenshot 2021-11-23 at 13.42.36.png

10 KiB

adrinux commented

2021-11-23 20:47:29 +00:00

Looking into 2. And finding that Firefox says var(--link) is not defined. Since link is a bulma variable that makes no sense, something wrong somewhere...and possibly related to @dpschen seeing that $dark and var(--dark) are different.

Edit: links are also not coloured in light mode.

Looking into 2. And finding that Firefox says var(--link) is not defined. Since link is a bulma variable that makes no sense, something wrong somewhere...and possibly related to @dpschen seeing that $dark and var(--dark) are different. Edit: links are also not coloured in light mode.

konrad commented

2021-11-23 20:56:29 +00:00

@dpschen The two tooltips in your screenshot have the exact same color (#374151).

Are you sure you have the correct screenshots?

@dpschen The two tooltips in your screenshot have the exact same color (`#374151`). Are you sure you have the correct screenshots?

konrad referenced a pull request from vikunja/frontend that will close this issue

2021-11-23 20:57:10 +00:00

fix(dark mode): dark mode adjustments #1069

konrad commented

2021-11-23 20:57:46 +00:00

@adrinux I've just opened a PR with a fix: vikunja/frontend#1069

@adrinux I've just opened a PR with a fix: https://kolaente.dev/vikunja/frontend/pulls/1069

adrinux referenced this issue from vikunja/frontend

2021-11-23 21:02:17 +00:00

fix(dark mode): dark mode adjustments #1069

konrad commented

2021-11-23 21:12:46 +00:00

The date picker needs fixing as well:

The date picker needs fixing as well: ![image](/attachments/f57e21d2-7a1c-4581-ba3c-49c0ddf250e1)

image.png

35 KiB

dpschen commented

2021-11-23 21:18:05 +00:00

@dpschen The two tooltips in your screenshot have the exact same color (#374151).

Are you sure you have the correct screenshots?

They screenshots were correct. But you are right!

I think I had a blue area somewhere around when I made those screenshots.
I checked multiple times, but never the value…

> @dpschen The two tooltips in your screenshot have the exact same color (`#374151`). > > Are you sure you have the correct screenshots? They screenshots were correct. But you are right! I think I had a blue area somewhere around when I made those screenshots. I checked multiple times, but never the value…

konrad closed this issue

2021-11-23 21:20:51 +00:00

konrad reopened this issue

2021-11-23 21:31:44 +00:00

konrad referenced a pull request from vikunja/frontend that will close this issue

2021-11-23 21:58:01 +00:00

fix(dark mode): flatpickr colors #1070

konrad commented

2021-11-23 21:58:21 +00:00

Another PR for the datepicker: vikunja/frontend#1070

Another PR for the datepicker: https://kolaente.dev/vikunja/frontend/pulls/1070

dpschen closed this issue