Styling issues with share links #1142

Closed
opened 8 months ago by konrad · 6 comments
Owner
  • The spacing around the logo is too much
  • The filters and search button should not have a weired spacing to the right
  • On mobile, the buttons and list view switch overlap
  • The view switching buttons are not even clickable
* The spacing around the logo is too much * The filters and search button should not have a weired spacing to the right * On mobile, the buttons and list view switch overlap * The view switching buttons are not even clickable
konrad added the
kind/bug
label 8 months ago
Poster
Owner

@dpschen Do you think #816 could help here? Because than we could remove the absolute positioning hack used to pull the filter and search button to the top

@dpschen Do you think #816 could help here? Because than we could remove the absolute positioning hack used to pull the filter and search button to the top
Collaborator

This was my plan all along, yes =)
I also realized that ListGantt.vue and gantt-component.vue should probably be merged. Or at least the filter should be separated from the graphic, what would enable to position it better since it would be outside of gantt-component

This was my plan all along, yes =) I also realized that `ListGantt.vue` and `gantt-component.vue` should probably be merged. Or at least the filter should be separated from the graphic, what would enable to position it better since it would be outside of gantt-component
Collaborator

Would like to add:

  • sometimes contrast problems with logo on background.

Possible solutions might be (didn't try if it looks good):

  • a gradient from the top (using easing gradients)
  • logo outline / shadow. This might be tricky to implement in a way that it still looks good.
Would like to add: - sometimes contrast problems with logo on background. Possible solutions might be (didn't try if it looks good): - a gradient from the top (using [easing gradients](https://larsenwork.com/easing-gradients/)) - logo outline / shadow. This might be tricky to implement in a way that it still looks good.
Poster
Owner

I also realized that ListGantt.vue and gantt-component.vue should probably be merged. Or at least the filter should be separated from the graphic, what would enable to position it better since it would be outside of gantt-component

Definitely. The whole gantt chart needs some work...

I don't even recall why I separated the two.

sometimes contrast problems with logo on background.

Only in light / dark theme? Or with different backgrounds?

> I also realized that ListGantt.vue and gantt-component.vue should probably be merged. Or at least the filter should be separated from the graphic, what would enable to position it better since it would be outside of gantt-component Definitely. The whole gantt chart needs some work... I don't even recall why I separated the two. > sometimes contrast problems with logo on background. Only in light / dark theme? Or with different backgrounds?
Poster
Owner

Seems to be fine in the latest version, apart from the logo spacing.

Seems to be fine in the latest version, apart from the logo spacing.
konrad referenced this issue from a commit 3 weeks ago
konrad closed this issue 3 weeks ago
Poster
Owner

Fixed the logo spacing in 3becf8738b

Fixed the logo spacing in https://kolaente.dev/vikunja/frontend/commit/3becf8738b6b6eeb040593c3d05005c8e50baa64
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1142
Loading…
There is no content yet.