time fields in calendar widget don't update unless you click away first #1522

Open
opened 4 months ago by kylrth · 9 comments
kylrth commented 4 months ago

In any place where the calendar view shows up (e.g. deferring from list view, editing the due date from task detail, or modifying the ranges in "Upcoming"), when I edit the time I have to click away from either the hours or the minutes in order for it to actually update. So if I type 23<Tab>30 and then click "confirm", it only saves the hours and not the minutes. But if I click on the hours again and then click "confirm" it saves both fields.

In any place where the calendar view shows up (e.g. deferring from list view, editing the due date from task detail, or modifying the ranges in "Upcoming"), when I edit the time I have to click away from either the hours or the minutes in order for it to actually update. So if I type `23<Tab>30` and then click "confirm", it only saves the hours and not the minutes. But if I click on the hours again and then click "confirm" it saves both fields.
kylrth changed title from time fields in calendar view don't update unless you click away first to time fields in calendar widget don't update unless you click away first 4 months ago
Owner

I think that's an issue with the way the flatpickr component is set up in vue. Not sure if there's much we can do about that.

I think that's an issue with the way the flatpickr component is set up in vue. Not sure if there's much we can do about that.
Poster

Any chance you could point me upstream to where I can file a bug report on this? Seems like a common enough problem to want solved generally.

Any chance you could point me upstream to where I can file a bug report on this? Seems like a common enough problem to want solved generally.
Owner

Sure! The component we're using is this one: https://github.com/ankurk91/vue-flatpickr-component

Feel free to ping me in any issues you create (@kolaente on github).

Sure! The component we're using is this one: https://github.com/ankurk91/vue-flatpickr-component Feel free to ping me in any issues you create (@kolaente on github).
Poster

What versions of vue.js, flatpickr, and vue-flatpickr-component are we using?

Does it seem reasonable for me to use Vikunja to demonstrate the bug? I'm a little worried I won't be able to produce a MWE.

What versions of vue.js, flatpickr, and vue-flatpickr-component are we using? Does it seem reasonable for me to use Vikunja to demonstrate the bug? I'm a little worried I won't be able to produce a MWE.
Owner

All versions are here: https://kolaente.dev/vikunja/frontend/src/branch/main/package.json#L47

I think you can use Vikunja to demonstrate the bug. If they want a minimal reproducible version we can build one.

All versions are here: https://kolaente.dev/vikunja/frontend/src/branch/main/package.json#L47 I think you can use Vikunja to demonstrate the bug. If they want a minimal reproducible version we can build one.
Owner

Even better yet, the bug is reproducible in their demo: https://ankurk91.github.io/vue-flatpickr-component/

Even better yet, the bug is reproducible in their demo: https://ankurk91.github.io/vue-flatpickr-component/
Poster

Really? It's actually working for me there just fine.

Really? It's actually working for me there just fine.
Owner

Now that you say it... looks like it yes. Not quite sure how to proceed here.

@dpschen Do you have an idea?

Now that you say it... looks like it yes. Not quite sure how to proceed here. @dpschen Do you have an idea?
Collaborator

Sorry for getting back so late. Somehow I missed this.
The vue-flatpickr-component is written really bad.
I want to replace it with a custom solution (because flatpickr itself is fine).

Sorry for getting back so late. Somehow I missed this. The vue-flatpickr-component is written really bad. I want to replace it with a custom solution (because flatpickr itself is fine).
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.