OpenID Connect authentication error not displayed #2111

New Issue

xeruf · 2022-07-11T13:36:40Z

xeruf commented

2022-07-11 13:36:40 +00:00

First-time contributor

It is part of the URL, but not included in the interface:

It is part of the URL, but not included in the interface: ![image](/attachments/a23005bf-1506-4f50-a829-53474ec5cb03)

image.png

48 KiB

konrad commented

2022-07-11 13:39:56 +00:00

Not all openid providers return this the same way. The next release (currently in unstable) has better error handling and surfaces these errors to users.

👍 1

dpschen commented

2022-10-04 11:26:14 +00:00

@xeruf: Does this work now?

xeruf commented

2022-10-05 07:34:49 +00:00

First-time contributor

Artificiallt tested with this URL, there the error is not displayed:

https://DOMAIN/auth/openid/stackspin?error=invalid_request&error_description=The+request+is+missing+a+required+parameter%2C+includes+an+invalid+parameter+value%2C+includes+a+parameter+more+than+once%2C+or+is+otherwise+malformed.+Make+sure+that+the+various+parameters+are+correct%2C+be+aware+of+case+sensitivity+and+trim+your+parameters.+Make+sure+that+the+client+you+are+using+has+exactly+whitelisted+the+redirect_uri+you+specified.&state=70ewvu5i5z7

Artificiallt tested with this URL, there the error is not displayed: https://DOMAIN/auth/openid/stackspin?error=invalid_request&error_description=The+request+is+missing+a+required+parameter%2C+includes+an+invalid+parameter+value%2C+includes+a+parameter+more+than+once%2C+or+is+otherwise+malformed.+Make+sure+that+the+various+parameters+are+correct%2C+be+aware+of+case+sensitivity+and+trim+your+parameters.+Make+sure+that+the+client+you+are+using+has+exactly+whitelisted+the+redirect_uri+you+specified.&state=70ewvu5i5z7

konrad referenced this issue from a commit

2022-10-05 16:02:20 +00:00

feat(openid): show error message from query after being redirected from third party

konrad closed this issue

2022-10-05 16:02:20 +00:00

konrad commented

2022-10-05 16:02:29 +00:00

Should be fixed in 820db3e96d

Should be fixed in https://kolaente.dev/vikunja/frontend/commit/820db3e96d14c952d1149c8b83e93a0a24fcb2a5

👍 1

Sign in to join this conversation.