due today ends at 15:00 #2989

New Issue

zhzy0077 · 2023-01-23T05:44:08Z

zhzy0077 commented

2023-01-23 05:44:08 +00:00

First-time contributor

Description

TZ: Asia/Shanghai, not sure if relevent

Go to a list
Enter today test item
It shows ends at 15:00 today.

Expected: Should it be 00:00 tomorrow?

Vikunja Frontend Version

0.20.2

Vikunja API Version

0.20.1

Browser and version

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

### Description TZ: Asia/Shanghai, not sure if relevent 1. Go to a list 2. Enter *today test item* 3. It shows ends at 15:00 today. Expected: Should it be 00:00 tomorrow? ### Vikunja Frontend Version 0.20.2 ### Vikunja API Version 0.20.1 ### Browser and version Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![图片](/attachments/6d8c2e85-d047-4e0c-aabe-53324873b333) ![图片](/attachments/b6b99a74-067e-444b-897f-fb710eefef83)

图片.png

23 KiB

图片.png

30 KiB

zhzy0077 added the

kind/bug

label 2023-01-23 05:44:08 +00:00

konrad commented

2023-01-24 15:55:41 +00:00

If you don't provide a date when creating a new task it will use the nearest date, similar to the date picker. In your case you seem to have created the task after 12:00 and before 15:00, hence Vikunja picked 15:00 as the time.

konrad closed this issue

2023-01-24 15:55:41 +00:00

dpschen commented

2023-01-24 20:42:14 +00:00

I am also confused by this. Shouldn't this pick midnight as due date for today?

dpschen reopened this issue

2023-01-26 10:37:43 +00:00

zhzy0077 commented

2023-01-26 17:00:25 +00:00

First-time contributor

If you don't provide a date when creating a new task it will use the nearest date, similar to the date picker. In your case you seem to have created the task after 12:00 and before 15:00, hence Vikunja picked 15:00 as the time.

TBH I don't get it.

I provided a date by saying 'today xxxx'
When I created a task between 12:00 and 15:00, isn't the nearest date tomorrow 00:00?

> If you don't provide a date when creating a new task it will use the nearest date, similar to the date picker. In your case you seem to have created the task after 12:00 and before 15:00, hence Vikunja picked 15:00 as the time. TBH I don't get it. 1. I provided a date by saying 'today xxxx' 2. When I created a task between 12:00 and 15:00, isn't the nearest date tomorrow 00:00?

konrad commented

2023-01-27 11:42:33 +00:00

When I created a task between 12:00 and 15:00, isn't the nearest date tomorrow 00:00?

The way it is currently implemented, no. Vikunja looks for the next time in three-hour intervals (excluding night).

> When I created a task between 12:00 and 15:00, isn't the nearest date tomorrow 00:00? The way it is currently implemented, no. Vikunja looks for the next time in three-hour intervals (excluding night).

dpschen commented

2023-01-27 14:25:29 +00:00

Vikunja looks for the next time in three-hour intervals (excluding night).

I guess this is what is confusing me.

If I write 'today' what I would mean personally is that that task should be done 'any time today' meaning the due date should be either at midnight or even a bit later since 'my day' – in the sense of my being-awake time – usually ends after midnight.

If I write 'in the next few hours' the current setting would be fine. Maybe even for 'now'. I wouldn't expect the due date to include an hour if I didn't define one.

> Vikunja looks for the next time in three-hour intervals (excluding night). I guess this is what is confusing me. If I write 'today' what I would mean personally is that that task should be done 'any time today' meaning the due date should be either at midnight or even a bit later since 'my day' – in the sense of my being-awake time – usually ends after midnight. If I write 'in the next few hours' the current setting would be fine. Maybe even for 'now'. I wouldn't expect the due date to include an hour if I didn't define one.

konrad commented

2023-01-27 15:00:35 +00:00

I think this returns to the discussion we had in #809.

I wouldn't expect the due date to include an hour if I didn't define one.

The issue is the api expects to save the due date with a time. Hence we need to pick one when the user does not provide one.

I think this returns to the discussion we had in https://kolaente.dev/vikunja/frontend/issues/809. > I wouldn't expect the due date to include an hour if I didn't define one. The issue is the api expects to save the due date with a time. Hence we need to pick one when the user does not provide one.

dpschen commented

2023-01-27 15:49:05 +00:00

I think this returns to the discussion we had in #809.

You are right! For a quick fix I think that change would improve UX a lot. We should really rebase and merge #1378 .
The latter only fixes the view part though.

> I think this returns to the discussion we had in #809. You are right! For a quick fix I think that change would improve UX a lot. We should really rebase and merge https://kolaente.dev/vikunja/frontend/pulls/1378 . The latter only fixes the view part though.

Sign in to join this conversation.