Notifications are not localized #3211

New Issue

WofWca · 2023-03-08T09:36:41Z

WofWca commented

2023-03-08 09:36:41 +00:00

Description

"Vikunja Reminder" and "Show task" strings are not localized.

0ff0d8c5b8/src/models/task.ts (L230-L241)

I'm not sure if simply replacing them with t('... is right as the language can be changed in the user setting at any time.

Vikunja Frontend Version

2262b49aaf

Vikunja API Version

v1

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

### Description "Vikunja Reminder" and "Show task" strings are not localized. https://kolaente.dev/vikunja/frontend/src/commit/0ff0d8c5b89bd6a8b628ddbe6074f61797b6b9c1/src/models/task.ts#L230-L241 I'm not sure if simply replacing them with `t('...` is right as the language can be changed in the user setting at any time. ### Vikunja Frontend Version 2262b49aaf8270b727020ee52f1e7ed30ee00694 ### Vikunja API Version v1 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_

WofWca added the

kind/bug

label 2023-03-08 09:36:41 +00:00

konrad commented

2023-03-08 09:40:12 +00:00

That whole code is dead code as Google sunsetted the Chrome api we used to schedule the notifications. I think we should remove it. Or maybe save it for a time when we implement this with common browser notifications? But if we do that we can always get it back from git history so I'd say let's remove it.

😕 1

Sign in to join this conversation.