Notifications are not localized #3211
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#3211
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
"Vikunja Reminder" and "Show task" strings are not localized.
0ff0d8c5b8/src/models/task.ts (L230-L241)
I'm not sure if simply replacing them with
t('...
is right as the language can be changed in the user setting at any time.Vikunja Frontend Version
2262b49aaf
Vikunja API Version
v1
Browser and version
No response
Can you reproduce the bug on the Vikunja demo site?
Yes
Screenshots
No response
That whole code is dead code as Google sunsetted the Chrome api we used to schedule the notifications. I think we should remove it. Or maybe save it for a time when we implement this with common browser notifications? But if we do that we can always get it back from git history so I'd say let's remove it.