"List", "Gantt"... (view type) buttons are unclickable on narrower screens #2022

New Issue

WofWca · 2023-03-09T10:00:01Z

WofWca commented

2023-03-09 10:00:01 +00:00

Description

They are covered by the "filters" element. On screen widths from 800 to 1000 when the sidebar is open.

Vikunja Frontend Version

0eb78e32

Vikunja API Version

v0.20.1+150-4f62e978ef

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

### Description They are covered by the "filters" element. On screen widths from 800 to 1000 when the sidebar is open. ### Vikunja Frontend Version 0eb78e32 ### Vikunja API Version v0.20.1+150-4f62e978ef ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![image](/attachments/d263fce3-8afb-4f0d-9bbc-832958ff0782)

image.png

27 KiB

WofWca added the

kind/bug

label 2023-03-09 10:00:01 +00:00

dpschen commented

2023-03-09 11:45:55 +00:00

Good catch. We have some open branches that would conflict with a too invasive change here. There is a lot that could be optimised. For a quick-fix I think adding using grid or flex on switch-view-container seems to do the trick.

For this we would need to remove the absolute position from the .filter-container.
@konrad Is there any reason why that is still absolutely positioned? We refactored that area a bit so I think the original reason for that being absolute doesn't apply anymore.

What I also do not understand is, why the min and max-width here is needed: fd3e7e655d/src/styles/components/list.scss (L13-L18)

Good catch. We have some open branches that would conflict with a too invasive change here. There is a lot that could be optimised. For a quick-fix I think adding using grid or flex on `switch-view-container` seems to do the trick. For this we would need to remove the absolute position from the `.filter-container`. @konrad Is there any reason why that is still absolutely positioned? We refactored that area a bit so I think the original reason for that being absolute doesn't apply anymore. What I also do not understand is, why the min and max-width here is needed: https://kolaente.dev/vikunja/frontend/src/commit/fd3e7e655dbbd59f9a94db0f18a3ef4876cec059/src/styles/components/list.scss#L13-L18

konrad commented

2023-03-09 12:58:41 +00:00

Is there any reason why that is still absolutely positioned? We refactored that area a bit so I think the original reason for that being absolute doesn't apply anymore.

Not sure. I think the original reason was so that the search input animation works but also the positioning of the filter form. Since that's now a modal it should be fine to make this not absolutely positioned.

We need to make sure the kanban buckets height works on all screen sizes. There's too much calculation involved so that might break when we start to change things around the buttons.

> Is there any reason why that is still absolutely positioned? We refactored that area a bit so I think the original reason for that being absolute doesn't apply anymore. Not sure. I think the original reason was so that the search input animation works but also the positioning of the filter form. Since that's now a modal it should be fine to make this not absolutely positioned. We need to make sure the kanban buckets height works on all screen sizes. There's too much calculation involved so that might break when we start to change things around the buttons.

konrad referenced this issue from a commit

2024-02-07 14:00:34 +00:00

chore(deps): update dependency vitest to v0.14.1 (#2022)

Sign in to join this conversation.