Unread indicator not in the right spot #2044

Closed
opened 2023-04-06 12:25:13 +00:00 by Bouni · 8 comments

Description

I've noticed that the unread indicator is offset quite far from the bell icon

Vikunja Frontend Version

0.20.5

Vikunja API Version

v0.20.4

Browser and version

Firefox 111.0.1 (64-Bit) / Windows 11

Can you reproduce the bug on the Vikunja demo site?

No

Screenshots

grafik

### Description I've noticed that the unread indicator is offset quite far from the bell icon ### Vikunja Frontend Version 0.20.5 ### Vikunja API Version v0.20.4 ### Browser and version Firefox 111.0.1 (64-Bit) / Windows 11 ### Can you reproduce the bug on the Vikunja demo site? No ### Screenshots ![grafik](/attachments/84ebbe5b-7517-44ee-b957-fe5a6ccd9e31)
5.3 KiB
Bouni added the
kind/bug
label 2023-04-06 12:25:13 +00:00
Owner

Does it work on try or didn't you check it there?

Does it work on try or didn't you check it there?
Author

Not sure how to trigger a unread notification over there as there's only the demo user, right?

Not sure how to trigger a unread notification over there as there's only the demo user, right?
Owner

Registration is open, you'd need to create a new user, share a list with the demo user (or vice versa) and then create a task comment or similar with the other user.

Registration is open, you'd need to create a new user, share a list with the demo user (or vice versa) and then create a task comment or similar with the other user.
Author

Yep, same behavior:

grafik

Yep, same behavior: ![grafik](/attachments/2f6ba0b2-227d-4a61-ad57-6d2e8f93f629)
5.7 KiB
Member

Probably a position: relative; got missing. If we readd it we should add a comment for what it is for :)

Probably a `position: relative;` got missing. If we readd it we should add a comment for what it is for :)
Author

With a bit of fiddling I got it in the right position, not sure if there's a better way:

grafik

grafik

With a bit of fiddling I got it in the right position, not sure if there's a better way: ![grafik](/attachments/dd4e70ab-dcab-4fb0-94a8-59cca677651a) ![grafik](/attachments/fb55c0bd-3be4-49ef-ae09-2e0e92d5dca6)
Owner

I just checked it, looks like this only needs a position: relative on the outer container and then position: absolute on the dot, that lets us position it relative to that outer container and makes these indicators relatively easy.

I just checked it, looks like this only needs a `position: relative` on the outer container and then `position: absolute` on the dot, that lets us position it *relative* to that outer container and makes these indicators relatively easy.
Owner

Fixed in 8b90b45739

Fixed in https://kolaente.dev/vikunja/frontend/commit/8b90b45739418f447b885fc9b37438e325f61b32
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#2044
No description provided.