Enable code highlighting in Task Description #1758

New Issue

nullptr · 2020-12-18T15:30:16Z

nullptr commented

2020-12-18 15:30:16 +00:00

It appears that the MDE text editor doesn't have code highlighting enabled when using code blocks, would this be a useful feature to implement?

nullptr changed title from ~~Enable code highlighting in~~ to Enable code highlighting in Task Description

2020-12-18 15:30:54 +00:00

konrad commented

2020-12-18 16:01:03 +00:00

Hey, thanks for the suggestion!

I'm not quite sure if that's something easyMDE would need to implement or we when rendering the description. Do you mean highlighting while typing or when it is rendered?

Hey, thanks for the suggestion! I'm not quite sure if that's something easyMDE would need to implement or we when rendering the description. Do you mean highlighting while typing or when it is rendered?

konrad added the

kind/feature

label 2020-12-18 16:01:10 +00:00

nullptr commented

2020-12-18 16:09:12 +00:00

Sorry for the hastily typed issue, I fat fingered the submit button too early!

I mean just on render, I don't think easyMDE allows for syntax highlighting on edit.

More info on this can be found at https://github.com/NikulinIlya/vue-easymde/blob/master/doc/configuration_en.md under "codeSyntaxHighlighting", I believe.

Just a nice QoL change for people like me who use Vikunja for issue tracking.

Thank you for the prompt response! Keep up the amazing work.

Sorry for the hastily typed issue, I fat fingered the submit button too early! I mean just on render, I don't think easyMDE allows for syntax highlighting on edit. More info on this can be found at https://github.com/NikulinIlya/vue-easymde/blob/master/doc/configuration_en.md under "codeSyntaxHighlighting", I believe. Just a nice QoL change for people like me who use Vikunja for issue tracking. Thank you for the prompt response! Keep up the amazing work.

konrad commented

2020-12-18 16:15:33 +00:00

Thanks for the hint. I still think (since that's an easyMDE option) that's for syntax highlighting while typing. We're rendering the content ourselves in Vikunja with markedjs which I think would need to enable that separately. But that's something we'd need to test I guess.

Do you want to send a PR?

Thanks for the hint. I still think (since that's an easyMDE option) that's for syntax highlighting while typing. We're rendering the content ourselves in Vikunja with `markedjs` which I think would need to enable that separately. But that's something we'd need to test I guess. Do you want to send a PR?

konrad commented

2020-12-18 16:16:51 +00:00

Yup, looks like marked js has another option for syntaxhighlighting: https://github.com/markedjs/marked/blob/master/docs/USING_ADVANCED.md#alternative-using-reference

nullptr commented

2020-12-18 16:32:27 +00:00

Nice searching. Unfortunately I am not in a position right now for me to clone/debug, but thank you for pointing me in the right direction and giving a few pointers.