Make whole task clickable #1760

Closed
opened 2020-12-31 18:45:33 +00:00 by azymondrian · 3 comments

Right now the singleTaskInList component has cursor: pointer applied to it, this implies that clicking anywhere on the list would open the task details, but that is not the case.

I think we should either make the whole task a link, or remove the cursor: pointer attribute. I would prefer the former, but am not sure the best way to do it.

This could be as simple as moving the router-link higher up, but that could cause other issues.

Right now the singleTaskInList component has `cursor: pointer` applied to it, this implies that clicking anywhere on the list would open the task details, but that is not the case. I think we should either make the whole task a link, or remove the `cursor: pointer` attribute. I would prefer the former, but am not sure the best way to do it. This could be as simple as moving the router-link higher up, but that could cause other issues.
konrad added the
kind/bug
label 2020-12-31 18:59:45 +00:00
Owner

I think it would very well be possible to just move the <router-link> but we'd probably need to change the tag it has. And then there's the a11y aspect of doing that...

The other problem is we'd need to make sure the other things a task item can have are still clickable (things like the pen icon or the due date) without redirecting to the task.

What areas did you find that weren't clickable but looked like they were?

I think it would very well be possible to just move the `<router-link>` but we'd probably need to change the tag it has. And then there's the a11y aspect of doing that... The other problem is we'd need to make sure the other things a task item can have are still clickable (things like the pen icon or the due date) without redirecting to the task. What areas did you find that weren't clickable but looked like they were?
Author

I find it especially on the desktop view, where pretty much everything in the red box looks clickable but doesn't do anything when you click on it

I find it especially on the desktop view, where pretty much everything in the red box *looks* clickable but doesn't do anything when you click on it ![](https://kolaente.dev/attachments/b3d47d2e-016f-4878-bd50-9e3cf5d02c40)
Owner

Fixed in 2b852de06f, feel free to reopen if you have any problems.

Fixed in https://kolaente.dev/vikunja/frontend/commit/2b852de06f26aa5d7b4b4312a316080a89a17a39, feel free to reopen if you have any problems.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1760
No description provided.