Paste or attach images in to description or comments are brokens #2078

New Issue

massimiliano-dalcero · 2023-10-30T09:16:04Z

2023-10-30 09:16:04 +00:00

Description

When I'm pasting an image after screenshot in memory or upload image from disk pushing botton, the image are not insert into text.

Is visible only in attachemnts

This is an example when insert image inside description

This screenshot is an example when insert image inside comment (note tha descrioption was empty, but after insert image in comment text, appear a broken image inside description)

I try on my local installation, and screenshot are about https://try.vikunja.io with the same results

Vikunja Frontend Version

0.21.0+311-8e0ba555ed

Vikunja API Version

v0.21.0+189-66afe52afb

Browser and version

Chrome 118 and Firefox 118

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

### Description When I'm pasting an image after screenshot in memory or upload image from disk pushing botton, the image are not insert into text. Is visible only in attachemnts This is an example when insert image inside description ![image](/attachments/be45da00-470d-4448-a922-e09708f951c1) This screenshot is an example when insert image inside comment (note tha descrioption was empty, but after insert image in comment text, appear a broken image inside description) ![image](/attachments/30eb6c8d-4a7a-473e-8e89-4a636f36cbbc) I try on my local installation, and screenshot are about https://try.vikunja.io with the same results ### Vikunja Frontend Version 0.21.0+311-8e0ba555ed ### Vikunja API Version v0.21.0+189-66afe52afb ### Browser and version Chrome 118 and Firefox 118 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![image](/attachments/be45da00-470d-4448-a922-e09708f951c1) ![image](/attachments/30eb6c8d-4a7a-473e-8e89-4a636f36cbbc)

image.png

118 KiB

image.png

144 KiB

image.png

177 KiB

massimiliano-dalcero added the

kind/bug

label 2023-10-30 09:16:04 +00:00

massimiliano-dalcero changed title from ~~Paste or attach images in to description or comments are broken~~ to Paste or attach images in to description or comments are brokens

2023-10-30 09:16:39 +00:00

konrad added the

confirmed

label 2023-10-30 13:38:28 +00:00

konrad referenced this issue from a commit

2023-11-18 16:17:39 +00:00

fix(editor): correctly resolve images in descriptions

konrad closed this issue

2023-11-18 16:17:39 +00:00

konrad commented

2023-11-18 16:20:07 +00:00

Fixed in d3497c96d7 - please check with the next unstable build if the problem really went away.

Fixed in https://kolaente.dev/vikunja/frontend/commit/d3497c96d76b0545b05fb0ca09b54ac54b5626f4 - please check with the next unstable build if the problem really went away.

massimiliano-dalcero commented

2023-11-20 08:36:20 +00:00

Hello @knorad :)
First of all, I thank you for your commitment and work on this issue.

I tried the vikunja demo site and noticed some issues:

When I insert an image using a screenshot from the clipboard, a "blob" attachment is added.
Furthermore, the images are not resizable.

furthermore, when I paste or insert an image into a comment of the task, it does not appear on comment'stext, but is inserted into the task description. I don't know how to show it with screenshots

Best regards,
Massimiliano

Hello @knorad :) First of all, I thank you for your commitment and work on this issue. I tried the vikunja demo site and noticed some issues: When I insert an image using a screenshot from the clipboard, a "blob" attachment is added. Furthermore, the images are not resizable. ![image](/attachments/50e31f07-65bb-474d-9f9f-03f39e5071d2) furthermore, when I paste or insert an image into a comment of the task, it does not appear on comment'stext, but is inserted into the task description. I don't know how to show it with screenshots ![image](/attachments/dce76757-ac91-4a78-8a43-be7b7d87581b) Best regards, Massimiliano

image.png

536 KiB

image.png

224 KiB

massimiliano-dalcero reopened this issue

2023-11-20 08:38:35 +00:00

konrad commented

2023-11-20 09:06:09 +00:00

I wouldn't consider it a bug that images are not resizable.

When I insert an image using a screenshot from the clipboard, a "blob" attachment is added.

Which name should it have instead? Images pasted from the clipboard don't have filename information associated with them.

furthermore, when I paste or insert an image into a comment of the task, it does not appear on comment'stext, but is inserted into the task description. I don't know how to show it with screenshots

What's the difference between note and description?

I wouldn't consider it a bug that images are not resizable. > When I insert an image using a screenshot from the clipboard, a "blob" attachment is added. Which name should it have instead? Images pasted from the clipboard don't have filename information associated with them. > furthermore, when I paste or insert an image into a comment of the task, it does not appear on comment'stext, but is inserted into the task description. I don't know how to show it with screenshots What's the difference between note and description?

massimiliano-dalcero commented

2023-11-20 09:18:41 +00:00

Hello Konrad,

I wouldn't consider it a bug that images are not resizable.

When I insert an image using a screenshot from the clipboard, a "blob" attachment is added.

Which name should it have instead? Images pasted from the clipboard don't have filename information associated with them.

I used image from a screenshot saved in to clipboard, so I don't have a real file name, but the valid one is "image.png".
"Blob" shouldn't exist at all, as you can see there are lot of images of just 13bytes.

furthermore, when I paste or insert an image into a comment of the task, it does not appear on comment'stext, but is inserted into the task description. I don't know how to show it with screenshots

What's the difference between note and description?

When you write a comment on the task, the inserted image does not appear. Instead (sometimes) this appears in the text of the description instead of in the comment text space.
Anyway, it never appears in the comment :(

Hello Konrad, > I wouldn't consider it a bug that images are not resizable. > > > When I insert an image using a screenshot from the clipboard, a "blob" attachment is added. > > Which name should it have instead? Images pasted from the clipboard don't have filename information associated with them. I used image from a screenshot saved in to clipboard, so I don't have a real file name, but the valid one is "image.png". "Blob" shouldn't exist at all, as you can see there are lot of images of just 13bytes. > > furthermore, when I paste or insert an image into a comment of the task, it does not appear on comment'stext, but is inserted into the task description. I don't know how to show it with screenshots > > What's the difference between note and description? When you write a comment on the task, the inserted image does not appear. Instead (sometimes) this appears in the text of the description instead of in the comment text space. Anyway, it never appears in the comment :( ![image](/attachments/560930b4-8fbd-4a5d-9181-2b8eea4a041f)

image.png

173 KiB

konrad commented

2023-11-20 11:36:37 +00:00

I used image from a screenshot saved in to clipboard, so I don't have a real file name, but the valid one is "image.png".
"Blob" shouldn't exist at all, as you can see there are lot of images of just 13bytes.

Now I understood what you meant, thanks for clarifying. Should be fixed in debae2326e.

> I used image from a screenshot saved in to clipboard, so I don't have a real file name, but the valid one is "image.png". > "Blob" shouldn't exist at all, as you can see there are lot of images of just 13bytes. Now I understood what you meant, thanks for clarifying. Should be fixed in debae2326ec265857c07468e1b470ed4ea273019.

👍 1

massimiliano-dalcero commented

2023-11-20 12:48:19 +00:00

Thank you for your valuable response.

As soon as it's ready on https://try.vikunja.io/ I'll try everything and give you feedback :)

Thank you for your valuable response. As soon as it's ready on https://try.vikunja.io/ I'll try everything and give you feedback :)

konrad commented

2023-11-21 12:26:41 +00:00

Now all fixed in 0c58ea1ade. Please check with the next unstable build.

Now all fixed in https://kolaente.dev/vikunja/frontend/commit/0c58ea1adeb3ef0e91075e6abb6d078c82177861. Please check with the next unstable build.

👍 1

konrad closed this issue