Done bucket behaviour #1796

Open
opened 2021-06-09 22:39:51 +00:00 by SteveDinn · 16 comments

Few things I noticed about the "Done" bucket in KanBan mode:

  • Dragging an item out of the "Done" bucket should un-set its "doneness".
  • You shouldn't be able to add a new task directly to the "Done" bucket. What would be the point?
  • When intially marking a bucket as the "Done" bucket, it should mark all the tasks currently in it as done. A warning dialog might be prudent here.

Finally, a kind of unrelated item I found while verifying the above items:

  • Setting an item to 100% complete should make it "Done".
Few things I noticed about the "Done" bucket in KanBan mode: * Dragging an item out of the "Done" bucket should un-set its "doneness". * You shouldn't be able to add a new task directly to the "Done" bucket. What would be the point? * When intially marking a bucket as the "Done" bucket, it should mark all the tasks currently in it as done. A warning dialog might be prudent here. Finally, a kind of unrelated item I found while verifying the above items: * Setting an item to 100% complete should make it "Done".
Author

There was another condition, but I couldn't remember it until now:

  • Marking an item as "not done" should move it out of the "Done" bucket -- Perhaps back to the default bucket.
    Is history kept for these tasks? Perhaps it could be moved to the bucket it was in before it was moved to the "Done" bucket.
There was another condition, but I couldn't remember it until now: * Marking an item as "not done" should move it out of the "Done" bucket -- Perhaps back to the default bucket. Is history kept for these tasks? Perhaps it could be moved to the bucket it was in before it was moved to the "Done" bucket.
Owner

Dragging an item out of the "Done" bucket should un-set its "doneness".

Agreed, that sounds like a bug.

You shouldn't be able to add a new task directly to the "Done" bucket. What would be the point?

TBH, I did not consider that yet. Maybe to keep track of tasks you already did but forgot to add to the list before starting them? I don't know if that'd make sense.

Setting an item to 100% complete should make it "Done".

Although edge-casey, I think that would make sense.

Is history kept for these tasks? Perhaps it could be moved to the bucket it was in before it was moved to the "Done" bucket.

The history is not kept, so that wouldn't work. It could be something to think of if the history is persisted at some point in the future though.

> Dragging an item out of the "Done" bucket should un-set its "doneness". Agreed, that sounds like a bug. > You shouldn't be able to add a new task directly to the "Done" bucket. What would be the point? TBH, I did not consider that yet. Maybe to keep track of tasks you already did but forgot to add to the list before starting them? I don't know if that'd make sense. > Setting an item to 100% complete should make it "Done". Although edge-casey, I think that would make sense. > Is history kept for these tasks? Perhaps it could be moved to the bucket it was in before it was moved to the "Done" bucket. The history is not kept, so that wouldn't work. It could be something to think of if the history is persisted at some point in the future though.
Author

If there is no history for the task, then I guess you could move it back to the default (first) bucket.

If there is no history for the task, then I guess you could move it back to the default (first) bucket.
konrad added the
kind/feature
label 2021-07-19 09:22:08 +00:00

In kanban is there not a movement from left to right through the buckets with done being rightmost? (At least for ltr languages.)

Placing it in the next bucket left would make more sense to me than the first bucket.

Maybe that just means moving it out of 'Done' should be left to the user...

In kanban is there not a movement from left to right through the buckets with done being rightmost? (At least for ltr languages.) Placing it in the next bucket left would make more sense to me than the first bucket. Maybe that just means moving it out of 'Done' should be left to the user...
Owner

Maybe that just means moving it out of 'Done' should be left to the user...

I'd agree, but then what should happen when the user "undoes" the task for example from the task detail view?

> Maybe that just means moving it out of 'Done' should be left to the user... I'd agree, but then what should happen when the user "undoes" the task for example from the task detail view?

Maybe that just means moving it out of 'Done' should be left to the user...

I'd agree, but then what should happen when the user "undoes" the task for example from the task detail view?

Not entirely clear to me why using the detail view would make a difference. (I still think it would make most sense to move them to the next bucket left.)

> > Maybe that just means moving it out of 'Done' should be left to the user... > > I'd agree, but then what should happen when the user "undoes" the task for example from the task detail view? Not entirely clear to me why using the detail view would make a difference. (I still think it would make most sense to move them to the next bucket left.)
Owner

If you'd only move them to the next bucket left then yeah, the detail view wouldn't make a difference.

If you'd only move them to the next bucket left then yeah, the detail view wouldn't make a difference.

Actually, we switched to moving tasks right-to-left ;)
See https://notes.jorre.dev/notes/20200929113755-backwards_kanban.html

Anyways, I agree with all these issues, and I think keeping a history with an activity log when the task was moved or modified by whom would be great, even the otherwise quite lacking Nextcloud Deck has it:
image

And Wekan integrates it with the comments, which seems a sensible approach for Vikunja:
image

I think the ability to add tasks to the done bucket does no harm - for us the "Done" bucket is actually called "Check" and reviewed by the team regularly, so adding tasks there retroactivly makes sense - but yes, they should be checked off automatically.

Actually, we switched to moving tasks right-to-left ;) See https://notes.jorre.dev/notes/20200929113755-backwards_kanban.html Anyways, I agree with all these issues, and I think keeping a history with an activity log when the task was moved or modified by whom would be great, even the otherwise quite lacking Nextcloud Deck has it: ![image](/attachments/ecdbc54b-52c9-4776-ac36-bb65b2d8a756) And Wekan integrates it with the comments, which seems a sensible approach for Vikunja: ![image](/attachments/2ba51c75-3493-4bc9-b273-66095297f956) I think the ability to add tasks to the done bucket does no harm - for us the "Done" bucket is actually called "Check" and reviewed by the team regularly, so adding tasks there retroactivly makes sense - but yes, they should be checked off automatically.
Owner

Anyways, I agree with all these issues, and I think keeping a history with an activity log when the task was moved or modified by whom would be great, even the otherwise quite lacking Nextcloud Deck has it:

Agreed, there's an item in the backlog for this already.

> Anyways, I agree with all these issues, and I think keeping a history with an activity log when the task was moved or modified by whom would be great, even the otherwise quite lacking Nextcloud Deck has it: Agreed, there's an item in the backlog for this already.

One day, Vikunja will be integrated with Gitea for issue tracking, and this duplication won't be needed anymore ;)

One day, Vikunja will be integrated with Gitea for issue tracking, and this duplication won't be needed anymore ;)
Member

You shouldn't be able to add a new task directly to the "Done" bucket. What would be the point?

Just read this thread again and I disagre with this point.
Reason being: Sometimes you want to add a task later that you did already for the sake of documenting that you did it. This one extra button also doesn't really hurt. I also wouldn't add an option to make this user definable here because if we do that we'll end up having options for everything.

> You shouldn't be able to add a new task directly to the "Done" bucket. What would be the point? Just read this thread again and I disagre with this point. Reason being: Sometimes you want to add a task later that you did already for the sake of documenting that you did it. This one extra button also doesn't really hurt. I also wouldn't add an option to make this user definable here because if we do that we'll end up having options for everything.
Member

Adding these two links to stuff that we currently are working on / are on out roadmap regarding kanban:

  • We plan to move away from the current sortable.js wrapper that we use for the kanban functionality: https://my.vikunja.cloud/tasks/15846. Sortable.js itself is fine, just the vue plugin is currently not maintained. We already use a fork, but that basically just fixes a few things that were broken. The core of the plugin is written like it's for vue 2 (while we are now use vue 3) and I'm not aware of any plans to change that. We are still not sure which way we will go here but listed some alternatives in the task.
  • vikunja/frontend#1571: here we split the components of the kanban in order to reduce complexity. This should help us improve the reliabiltiy and functionality in the future and makes sense. Before we can go back to this we should finish the typescript migration and pinia integration.
Adding these two links to stuff that we currently are working on / are on out roadmap regarding kanban: - We plan to move away from the current sortable.js wrapper that we use for the kanban functionality: https://my.vikunja.cloud/tasks/15846. Sortable.js itself is fine, just the vue plugin is currently not maintained. We already use a fork, but that basically just fixes a few things that were broken. The core of the plugin is written like it's for vue 2 (while we are now use vue 3) and I'm not aware of any plans to change that. We are still not sure which way we will go here but listed some alternatives in the task. - https://kolaente.dev/vikunja/frontend/pulls/1571: here we split the components of the kanban in order to reduce complexity. This should help us improve the reliabiltiy and functionality in the future and makes sense. Before we can go back to this we should finish the typescript migration and pinia integration.
See also https://kolaente.dev/vikunja/frontend/issues/2338 and https://kolaente.dev/vikunja/frontend/issues/2246
Contributor

Dragging an item out of the "Done" bucket should un-set its "doneness"

I opened an MR for this: #3291

It makes sense, but could actually be breaking as some people might have an "archived" bucket or something. I guess adding a setting for this could work if required.

> Dragging an item out of the "Done" bucket should un-set its "doneness" I opened an MR for this: #3291 It makes sense, but could actually be breaking as some people might have an "archived" bucket or something. I guess adding a setting for this could work if required.

When intially marking a bucket as the "Done" bucket, it should mark all the tasks currently in it as done. A warning dialog might be prudent here.

And marking a bucket as Done should offer to move all done tasks to it

> When intially marking a bucket as the "Done" bucket, it should mark all the tasks currently in it as done. A warning dialog might be prudent here. And marking a bucket as Done should offer to move all done tasks to it
Owner

This should be relatively easy once we have bulk updates.

This should be relatively easy once we have bulk updates.
Sign in to join this conversation.
No Milestone
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1796
No description provided.