Don't reset activeFields after editing some field #590

Open
opened 3 weeks ago by andreymal · 1 comments

There's a small UI glitch in the task detail view:

  1. Click "Set a start date"
  2. Set some date, but don't click "Confirm"
  3. Click "Set an end date" while the start date widget is still open

The end date field became visible, but disappeared immediately after saving start date, so I have to click "Set an end date" again.

It's easy to see that hiding is caused by calling setActiveFields() in the saveTask method, so I think there is a need to remember fields fields that should remain active after saving (or just deleting this call, but it exists for some reason?)

(I wanted to make a PR but couldn't come up with a variable name 🙁)

(P.S. There are many small UI glitches, maybe I'll create a meta-issue someday)

There's a small UI glitch in the task detail view: 1. Click "Set a start date" 2. Set some date, but don't click "Confirm" 3. Click "Set an end date" while the start date widget is still open The end date field became visible, but disappeared immediately after saving start date, so I have to click "Set an end date" again. It's easy to see that hiding is caused by calling [setActiveFields()](https://kolaente.dev/vikunja/frontend/src/commit/7355204d2f7367a52d27b5079087b231c6caf5ae/src/views/tasks/TaskDetailView.vue#L615) in the `saveTask` method, so I think there is a need to remember fields fields that should remain active after saving (or just deleting this call, but it exists for some reason?) (I wanted to make a PR but couldn't come up with a variable name 🙁) (P.S. There are many small UI glitches, maybe I'll create a meta-issue someday) ![](https://i.imgur.com/ZIDPZL3.gif)
Owner

I think that call to setActiveFields() is save to remove. IIRC I've put it in back then precisely because I wanted to hide all fields without a value after one was set.

Another way to solve this would be to add a check to see if a new field was called (click on a "set"-button while another dialog was still open) but I think that'd get very complicated very quickly.

I think that call to `setActiveFields()` is save to remove. IIRC I've put it in back then precisely because I wanted to hide all fields without a value after one was set. Another way to solve this would be to add a check to see if a new field was called (click on a "set"-button while another dialog was still open) but I think that'd get very complicated very quickly.
konrad added the
kind/bug
label 3 weeks ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.