Clearer language and positioning on the description and comment edit links/buttons #1816

Closed
opened 2021-08-12 11:31:14 +00:00 by adrinux · 9 comments

This is minor but it's been niggling me for a while.

'Done' is for task completion.

But we also have a 'Done' button when editing the description - more than one I've clicked the wrong done :) They are only a few pixels away from each other sometimes.

I wonder if using 'finish' would be clearer. Or perhaps the done button on the description edit needs to be below the text box as it is for comments.

Then there's the fact that the description gets a pencil button and an edit link but the comments only get a tiny grey 'edit' text and 'done'.

On the whole it just feels like description and comment fields aren't all that different and shouldn't have different edit/done UI.

It may be possible to make them more consistent whilst also moving the confusing 'done' button on the description edit.

This is minor but it's been niggling me for a while. 'Done' is for task completion. But we also have a 'Done' button when editing the description - more than one I've clicked the wrong done :) They are only a few pixels away from each other sometimes. I wonder if using 'finish' would be clearer. Or perhaps the done button on the description edit needs to be below the text box as it is for comments. Then there's the fact that the description gets a pencil button and an edit link but the comments only get a tiny grey 'edit' text and 'done'. On the whole it just feels like description and comment fields aren't all that different and shouldn't have different edit/done UI. It may be possible to make them more consistent whilst also moving the confusing 'done' button on the description edit.
Owner

I think I understand the friction. Ideally I'd like to keep the "Done!" button (the one to mark a task as done) and rename the one to finish editing. Maybe "finish" would work.

Then there's the fact that the description gets a pencil button and an edit link but the comments only get a tiny grey 'edit' text and 'done'.

The problem with comments is they also have a "delete" action which needs to be placed somehwere. I'm not 100% sold on the way it currently is, that was just a way where the placement felt nice. My problem is it's not that obvious for a placement. Open for ideas.

I think I understand the friction. Ideally I'd like to keep the "Done!" button (the one to mark a task as done) and rename the one to finish editing. Maybe "finish" would work. > Then there's the fact that the description gets a pencil button and an edit link but the comments only get a tiny grey 'edit' text and 'done'. The problem with comments is they also have a "delete" action which needs to be placed somehwere. I'm not 100% sold on the way it currently is, that was just a way where the placement felt nice. My problem is it's not that obvious for a placement. Open for ideas.
Author

100% agree on keeping the Done button for tasks :)

I feel like the options for comments are ok, including placement.

I think I'd like to see the Description edit options match the comments in terms of placement. I'm not totally sold on 'finish', 'done' works well to end editing too.

I think most of the problem is the placement of the buttons, particulary 'done' at the top right of the description edit area where it can end up next to the done task button, a button which is rightly much bigger & brighter.

I think moving the description edit buttons below the description area might remove any need to change the wording, it would also mean the edit/done and edit/done|delete of description and comments would be consistent.

100% agree on keeping the Done button for tasks :) I feel like the options for comments are ok, including placement. I think I'd like to see the Description edit options match the comments in terms of placement. I'm not totally sold on 'finish', 'done' works well to end editing too. I think most of the problem is the placement of the buttons, particulary 'done' at the top right of the description edit area where it can end up next to the done task button, a button which is rightly much bigger & brighter. I think moving the description edit buttons below the description area might remove any need to change the wording, it would also mean the edit/done and edit/done|delete of description and comments would be consistent.
Owner

I've moved this to the bottom of the description in 9c6369e8d8.

Here's how it looks:
image
image

(not quite sure on the color of the "Done" - My intention was to highlight it since everything there is gray already which may make it hard to spot the "Done")

What do you think?

I've moved this to the bottom of the description in 9c6369e8d8ac31dea18218f7f387d2d2277070cc. Here's how it looks: ![image](/attachments/88c36fe5-dc36-40e3-b555-b7af2a85104f) ![image](/attachments/f3db7c9d-7ef9-40d4-9984-8dffde69b209) (not quite sure on the color of the "Done" - My intention was to highlight it since everything there is gray already which may make it hard to spot the "Done") What do you think?
Author

I think that would solve my issue :)

I take your point about it being hard to spot, at least compared to the larger button-style Done that moved.

Any reason not to make it more button like as it was before?

I think that would solve my issue :) I take your point about it being hard to spot, at least compared to the larger button-style Done that moved. Any reason not to make it more button like as it was before?
Owner

Any reason not to make it more button like as it was before?

No real reason, I just didn't think of it. Makes sense I think.

> Any reason not to make it more button like as it was before? No real reason, I just didn't think of it. Makes sense I think.
Owner

I've now made "save" a real button in 08a34d8a68. Should be ready to check out in ~30 min on try.

I think this is solved now, closing. Feel free to ping or reopen if you think it is not.

I've now made "save" a real button in 08a34d8a68d6b525b57dc38cf4b7b82571bfb501. Should be ready to check out in ~30 min on try. I think this is solved now, closing. Feel free to ping or reopen if you think it is not.
Author

This seems to have introduced a bug. 'Comment' button now has a 'Done' text button above it.

(It allows you to submit the comment but no username appears on the comment.)

This seems to have introduced a bug. 'Comment' button now has a 'Done' text button above it. (It allows you to submit the comment but no username appears on the comment.)
adrinux reopened this issue 2021-08-20 11:56:04 +00:00
Owner

Should be fixed now, the problem was an issue with the ci so it did not release a version with the fix. Please check again on try.

Should be fixed now, the problem was an issue with the ci so it did not release a version with the fix. Please check again on try.
Author

This was fixed and improved upon. Closing.

This was fixed and improved upon. Closing.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1816
No description provided.