Clearer language and positioning on the description and comment edit links/buttons #1816
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1816
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is minor but it's been niggling me for a while.
'Done' is for task completion.
But we also have a 'Done' button when editing the description - more than one I've clicked the wrong done :) They are only a few pixels away from each other sometimes.
I wonder if using 'finish' would be clearer. Or perhaps the done button on the description edit needs to be below the text box as it is for comments.
Then there's the fact that the description gets a pencil button and an edit link but the comments only get a tiny grey 'edit' text and 'done'.
On the whole it just feels like description and comment fields aren't all that different and shouldn't have different edit/done UI.
It may be possible to make them more consistent whilst also moving the confusing 'done' button on the description edit.
I think I understand the friction. Ideally I'd like to keep the "Done!" button (the one to mark a task as done) and rename the one to finish editing. Maybe "finish" would work.
The problem with comments is they also have a "delete" action which needs to be placed somehwere. I'm not 100% sold on the way it currently is, that was just a way where the placement felt nice. My problem is it's not that obvious for a placement. Open for ideas.
100% agree on keeping the Done button for tasks :)
I feel like the options for comments are ok, including placement.
I think I'd like to see the Description edit options match the comments in terms of placement. I'm not totally sold on 'finish', 'done' works well to end editing too.
I think most of the problem is the placement of the buttons, particulary 'done' at the top right of the description edit area where it can end up next to the done task button, a button which is rightly much bigger & brighter.
I think moving the description edit buttons below the description area might remove any need to change the wording, it would also mean the edit/done and edit/done|delete of description and comments would be consistent.
I've moved this to the bottom of the description in
9c6369e8d8
.Here's how it looks:
(not quite sure on the color of the "Done" - My intention was to highlight it since everything there is gray already which may make it hard to spot the "Done")
What do you think?
I think that would solve my issue :)
I take your point about it being hard to spot, at least compared to the larger button-style Done that moved.
Any reason not to make it more button like as it was before?
No real reason, I just didn't think of it. Makes sense I think.
I've now made "save" a real button in
08a34d8a68
. Should be ready to check out in ~30 min on try.I think this is solved now, closing. Feel free to ping or reopen if you think it is not.
This seems to have introduced a bug. 'Comment' button now has a 'Done' text button above it.
(It allows you to submit the comment but no username appears on the comment.)
Should be fixed now, the problem was an issue with the ci so it did not release a version with the fix. Please check again on try.
This was fixed and improved upon. Closing.