404 notification when comments are disabled #1827

New Issue

stephen-hill · 2021-09-17T09:17:08Z

stephen-hill commented

2021-09-17 09:17:08 +00:00

First, thank you for making Vikunja 👍

On my self-hosted instance, I have comments disabled:

enabletaskcomments: false

However, when opening as task, I observe two problems:

A red 404 notification is displayed
The comments box is still visible

Ideally, the Frontend should know from /info that comments are enabled/disabled and change behaviour accordingly.

Cheers
Stephen

First, thank you for making Vikunja 👍 On my self-hosted instance, I have comments disabled: ```yaml enabletaskcomments: false ``` However, when opening as task, I observe two problems: 1. A red 404 notification is displayed ![image](/attachments/fa7448b2-42ee-42ba-96d6-48a7f7bc7d53) 2. The comments box is still visible ![image](/attachments/a8e6b777-4468-4499-a217-69ceb1468654) Ideally, the Frontend should know from /info that comments are enabled/disabled and change behaviour accordingly. Cheers Stephen

image.png

1.6 KiB

image.png

17 KiB

👍 1

stephen-hill commented

2021-09-17 09:50:13 +00:00

I forgot to add that I'm using the following versions:

Vikunja api version v0.18.1+1-111ac92619
Built with go1.16.7

Frontend Version: 0.18.1

I forgot to add that I'm using the following versions: Vikunja api version v0.18.1+1-111ac92619 Built with go1.16.7 Frontend Version: 0.18.1

konrad added the

kind/bug

label 2021-09-21 19:39:31 +00:00

konrad commented

2021-09-26 11:45:29 +00:00

Fixed in ae8db176db and e918b82cfa. A new unstable release should be ready for testing in ~30 min. Please note that this is a fix affecting both frontend and api, if you want to test it out you'll need to update api and frontend.

Fixed in https://kolaente.dev/vikunja/api/commit/ae8db176db57fa6176e00b87924f70352332ca66 and https://kolaente.dev/vikunja/frontend/commit/e918b82cfa7dbf5d645a5da6542a89b19d5bba46. A new unstable release should be ready for testing in ~30 min. Please note that this is a fix affecting both frontend and api, if you want to test it out you'll need to update api and frontend.

👍 1

konrad closed this issue

2021-09-26 11:45:32 +00:00

stephen-hill commented

2021-09-26 20:06:06 +00:00

@konrad Thank you

Sign in to join this conversation.