Keyboard shortcuts messing up description/comment text fields in iOS/Safari #1830

New Issue

OrangePony · 2021-09-21T21:27:02Z

OrangePony commented

2021-09-21 21:27:02 +00:00

Under iOS Safari (tested under iOS 14.4.2) all active single-key keyboard shortcuts ('a', 'l', 'd', 'f', 'r') trigger their respective action even when typed in from a description and/or title field.

In the attached video, you can see what happens when an 'a' and an 'l' are typed into a Description field. This does not happen in the 'Labels', 'Assignees' nor 'Title' text boxes.

This makes the frontend mostly unusable in the current state under iOS. Could these shortcuts perhaps be disabled under iOS for the time being? Can they be disabled manually in an easy way?

Under iOS Safari (tested under iOS 14.4.2) all active single-key keyboard shortcuts ('a', 'l', 'd', 'f', 'r') trigger their respective action even when typed in from a description and/or title field. In the attached video, you can see what happens when an 'a' and an 'l' are typed into a Description field. This does not happen in the 'Labels', 'Assignees' nor 'Title' text boxes. This makes the frontend mostly unusable in the current state under iOS. Could these shortcuts perhaps be disabled under iOS for the time being? Can they be disabled manually in an easy way?

iOS Safari Keyboard Shortcut issue.mp4

3.2 MiB

konrad added the

kind/bug

label 2021-09-21 21:57:36 +00:00

konrad commented

2021-09-21 21:59:48 +00:00

I'm guessing this is caused by these fields using contenteditable instead of "real" input fields. Since this seems to only happen on ios mobile, I think we can get away with just disabling the shortcuts in that case.

@dpschen Do you have a good idea how to solve this without disabling them?

Safari really is the new IE.

I'm guessing this is caused by these fields using contenteditable instead of "real" input fields. Since this seems to only happen on ios mobile, I think we can get away with just disabling the shortcuts in that case. @dpschen Do you have a good idea how to solve this without disabling them? _Safari really is the new IE._

👍 1

OrangePony commented

2021-09-22 08:05:00 +00:00

This seems like an acceptable workaround, given that these shortcuts are basically useless from a mobile device IMHO.

dpschen commented

2021-09-22 11:35:21 +00:00

Maybe this pull request solves this: vikunja/frontend#775
I think it makes sense to prevent the shortcuts while editing in the field, because they kind of can't work :D

Or is that what you meant by disabling the shortcuts in that case @konrad?

I have an iPhone but my vikunja setup is currently really crappy docker-compose where I don't know how to make the api available via the network, so I couldn't test the fix. Safari on macOS doesn't seem to have that problem (couldn't reproduce the error in the first place). @OrangePony maybe you can test :)

Maybe this pull request solves this: https://kolaente.dev/vikunja/frontend/pulls/775 I think it makes sense to prevent the shortcuts while editing in the field, because they kind of can't work :D Or is that what you meant by <q>disabling the shortcuts</q> in that case @konrad? I have an iPhone but my vikunja setup is currently really crappy docker-compose where I don't know how to make the api available via the network, so I couldn't test the fix. Safari on macOS doesn't seem to have that problem (couldn't reproduce the error in the first place). @OrangePony maybe you can test :)

dpschen referenced this issue from vikunja/frontend

2021-09-22 16:23:49 +00:00

fix: prevent vue-shortkey use in elements with contenteditable #775

konrad commented

2021-09-22 16:24:37 +00:00

Or is that what you meant by "disabling the shortcuts" in that case

@dpschen Yeah either that or disabling shortcuts on mobile all together. The fix in your pr seems a lot simpler though so I think we can merge that and the problem should go away.

You should be able to download a darwin api binary from here - in theory that should be exposed to the network by default. (but I don't know anything about MacOS firewall settings)
Another option would be to use the api from try with your frontend - as long as you have figured out how to access the frontend you're building on your PC on the iPhone, you should be able to change the URL to that (in the browser).

> Or is that what you meant by "disabling the shortcuts" in that case @dpschen Yeah either that or disabling shortcuts on mobile all together. The fix in your pr seems a lot simpler though so I think we can merge that and the problem should go away. You should be able to download a darwin api binary from [here](https://dl.vikunja.io/api/unstable) - in theory that should be exposed to the network by default. (but I don't know anything about MacOS firewall settings) Another option would be to use the api from try with your frontend - as long as you have figured out how to access the frontend you're building on your PC on the iPhone, you should be able to change the URL to that (in the browser).

OrangePony commented

2021-09-29 20:50:26 +00:00

Hello! I can confirm that pull request #775 works fine, just tested locally with an iPhone! All "one key" keyboard shortcuts work fine.

🎉 1

konrad commented

2021-09-29 20:51:36 +00:00

Sounds great! I'm closing this as resolved, feel free to reopen if you have any other issues.

konrad closed this issue

2021-09-29 20:51:36 +00:00

Sign in to join this conversation.