Login component doesn't work with (some) browsers' password managers #1714

Closed
opened 2020-04-02 18:33:17 +00:00 by deanishe · 3 comments

Vue bindings don't work with autofilled inputs on some browsers (e.g. Firefox for iOS). This is a security feature.

As a result, Vikunja submits empty credentials on login.

Username & password should be retrieved manually from the fields in the login handler (user interaction tells the browser it's okay to let scripts see the field contents).

More details in this React issue.

Vue bindings don't work with autofilled inputs on some browsers (e.g. Firefox for iOS). This is a security feature. As a result, Vikunja submits empty credentials on login. Username & password should be retrieved manually from the fields in the login handler (user interaction tells the browser it's okay to let scripts see the field contents). [More details in this React issue](https://github.com/facebook/react/issues/1159#issuecomment-506584346).
Owner

Interesting issue I wasn't aware of.

I'll send a fix.

Interesting issue I wasn't aware of. I'll send a fix.
Owner

Pushed a fix in 27e2839f4c, an updated version is in the process of being released. Please test again once its ready in a few minutes.

You should be able to verify this on try.vikunja.io.

Pushed a fix in https://kolaente.dev/vikunja/frontend/commit/27e2839f4cffdd04a7cd8862cca0344a9c42c315, an updated version is in the process of being released. Please test again once its ready in a few minutes. You should be able to verify this on try.vikunja.io.
Author

Works like a charm! Thank you very much!

Works like a charm! Thank you very much!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1714
No description provided.