Use @vite/plugin-legacy #1835

Closed
opened 2021-09-23 15:34:11 +00:00 by dpschen · 8 comments
Member

This will increase build time, but might fix some issues with older browsers. Maybe also with safari (not sure).
https://github.com/vitejs/vite/tree/main/packages/plugin-legacy

This will increase build time, but might fix some issues with older browsers. Maybe also with safari (not sure). https://github.com/vitejs/vite/tree/main/packages/plugin-legacy
Owner

Looks like that could work. We don't need IE 11 support though.

Do you want to send a PR?

Looks like that could work. We don't need IE 11 support though. Do you want to send a PR?
konrad added the
kind/feature
label 2021-09-23 18:30:45 +00:00
Author
Member

Done in vikunja/frontend#829

@konrad: might make sense to only use the modern-only build in the electron app.
Do you think that makes sense? If so maybe we should create a new ticket for that.

Other than that I guess this ticket can be closed.

(I kind of have a déjà-vu right now: could have sworn I wrote the same thing here already :P)

Done in https://kolaente.dev/vikunja/frontend/pulls/829 @konrad: might make sense to only use the modern-only build in the electron app. Do you think that makes sense? If so maybe we should create a new ticket for that. Other than that I guess this ticket can be closed. (I kind of have a déjà-vu right now: could have sworn I wrote the same thing here already :P)
Owner

IIRC modern browsers will only load the modern bundle by default? That means there's nothing left to do for the electron app since that is basically a modern browser.

IIRC modern browsers will only load the modern bundle by default? That means there's nothing left to do for the electron app since that is basically a modern browser.
Author
Member

@konrad Yes! but it will decrease the bundle size if the app is packaged just with the modern build.

@konrad Yes! but it will decrease the bundle size if the app is packaged just with the modern build.
Owner

Good point.

I'm not sure if that's actually worth the hassle since the total bundle since for the electron app is 100MB+. Reducing that by 2-3MB doesn't seem like much.

Feel free to put up a PR though 🙂

Good point. I'm not sure if that's actually worth the hassle since the total bundle since for the electron app is 100MB+. Reducing that by 2-3MB doesn't seem like much. Feel free to put up a PR though 🙂
Author
Member

Maybe tauri can help to make the 2-3mb more relevant :P

Kidding .. maybe somthing for another day.
Regarding the PR: if I see it correctly the electron app currently just downloads the finished build. So not sure how I could get the data of the modern-only.

Maybe [tauri](https://tauri.studio/en/) can help to make the 2-3mb more relevant :P Kidding .. maybe somthing for another day. Regarding the PR: if I see it correctly the electron app currently just [downloads the finished build](https://kolaente.dev/vikunja/desktop/src/branch/main/.drone.yml#L51). So not sure how I could get the data of the modern-only.
Owner

Oh I never heard of tauri, looks really interesting!

Regarding the PR: if I see it correctly the electron app currently just downloads the finished build. So not sure how I could get the data of the modern-only.

Yup, you'd probably add another build step to checkout the frontend and build the modern bundle. That's what I meant with "worth the hassle" 😀

Oh I never heard of tauri, looks really interesting! > Regarding the PR: if I see it correctly the electron app currently just downloads the finished build. So not sure how I could get the data of the modern-only. Yup, you'd probably add another build step to checkout the frontend and build the modern bundle. That's what I meant with "worth the hassle" 😀
Author
Member

Yeah I think I won't do that now, but might be good to rembember the modern-only build for some time later :)

Yeah I think I won't do that now, but might be good to rembember the modern-only build for some time later :)
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1835
No description provided.