Use @vite/plugin-legacy #1835
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#1835
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This will increase build time, but might fix some issues with older browsers. Maybe also with safari (not sure).
https://github.com/vitejs/vite/tree/main/packages/plugin-legacy
Looks like that could work. We don't need IE 11 support though.
Do you want to send a PR?
Done in vikunja/frontend#829
@konrad: might make sense to only use the modern-only build in the electron app.
Do you think that makes sense? If so maybe we should create a new ticket for that.
Other than that I guess this ticket can be closed.
(I kind of have a déjà-vu right now: could have sworn I wrote the same thing here already :P)
IIRC modern browsers will only load the modern bundle by default? That means there's nothing left to do for the electron app since that is basically a modern browser.
@konrad Yes! but it will decrease the bundle size if the app is packaged just with the modern build.
Good point.
I'm not sure if that's actually worth the hassle since the total bundle since for the electron app is 100MB+. Reducing that by 2-3MB doesn't seem like much.
Feel free to put up a PR though 🙂
Maybe tauri can help to make the 2-3mb more relevant :P
Kidding .. maybe somthing for another day.
Regarding the PR: if I see it correctly the electron app currently just downloads the finished build. So not sure how I could get the data of the modern-only.
Oh I never heard of tauri, looks really interesting!
Yup, you'd probably add another build step to checkout the frontend and build the modern bundle. That's what I meant with "worth the hassle" 😀
Yeah I think I won't do that now, but might be good to rembember the modern-only build for some time later :)