Duplicate "edit" action in task detail if no description available. #1844

Closed
opened 2021-10-04 13:50:39 +00:00 by dpschen · 4 comments
Member

One of those should be removed.

I was not sure of all the cases that the Editor component supports so I didn't want to break anything.

One of those should be removed. I was not sure of all the cases that the Editor component supports so I didn't want to break anything.
dpschen added the
changes requested
label 2021-10-04 13:50:39 +00:00
Owner

Maybe that can be changed to only show the edit button (below) when there is some text?

Maybe that can be changed to only show the edit button (below) when there is some text?
Author
Member

Yes that makes sense. I didn't create a pull request because I was not sure if I'm correctly understand all the possible cases (there are a lot of combinations).

Yes that makes sense. I didn't create a pull request because I was not sure if I'm correctly understand all the possible cases (there are a lot of combinations).
Owner

I think the task description and comments are the only cases when edit is enabled, have you checked that?

I think the task description and comments are the only cases when edit is enabled, have you checked that?
konrad self-assigned this 2021-10-04 19:15:42 +00:00
Owner

Fixed in 19a561c8e6

Fixed in https://kolaente.dev/vikunja/frontend/commit/19a561c8e6cdd43f8bca246e1a883cd642e11ccb
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#1844
No description provided.