Vue 3 Migration issues #868

Open
opened 3 months ago by konrad · 9 comments
konrad commented 3 months ago
Owner

Follow-up task from #815 to collect all post-migration issues.

TODOs

  • After setting a label color, it gets reset to black
  • Opening the quick add menu yields Message compilation error: Invalid linked format but seems to work fine otherwise
  • Loading state does not work when loading tasks on a list
  • The edit task pane in task list looks broken
  • [Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list". and similar for other routes
  • Direct store manipulation in task.js vuex module - there's FIXMEs in the relevant places
  • Invalid prop: type check failed for prop "currentPage". Expected Number with value NaN, got Undefined when accessing list views - PR: #1002
Follow-up task from #815 to collect all post-migration issues. ### TODOs * [ ] After setting a label color, it gets reset to black * [x] Opening the quick add menu yields `Message compilation error: Invalid linked format` but seems to work fine otherwise * [x] Loading state does not work when loading tasks on a list * [x] The edit task pane in task list looks broken * [ ] `[Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list".` and similar for other routes * [ ] Direct store manipulation in task.js vuex module - there's `FIXME`s in the relevant places * [x] `Invalid prop: type check failed for prop "currentPage". Expected Number with value NaN, got Undefined` when accessing list views - PR: https://kolaente.dev/vikunja/frontend/pulls/1002
konrad self-assigned this 3 months ago
dpschen was assigned by konrad 3 months ago
Collaborator

Opening the quick add menu yields Message compilation error: Invalid linked format but seems to work fine otherwise

This is because of all the @s in the translation (see screenshot)

> Opening the quick add menu yields Message compilation error: Invalid linked format but seems to work fine otherwise This is because of all the `@`s in the translation (see screenshot)
Collaborator

[Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list". and similar for other routes

This should be solved with #816 (not yet ready).

`[Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list". and similar for other routes` This should be solved with https://kolaente.dev/vikunja/frontend/pulls/816 (not yet ready).
Collaborator

@konrad: where was this fixed:

The edit task pane in task list looks broken

@konrad: where was this fixed: > The edit task pane in task list looks broken
Poster
Owner

@dpschen very good question.

@dpschen very good question.
Collaborator

Shall I remove that tick?

Shall I remove that tick?
Poster
Owner

I mean it's not broken anymore (at least as far as I was able to see it?). Just don't remember where it was fixed 😃

I mean it's not broken anymore (at least as far as I was able to see it?). Just don't remember where it was fixed 😃
Collaborator

Ahh I think I thought it meant the edit pane in the gantt view:

(still don't know how to reference uploaded images here)

Ahh I think I thought it meant the edit pane in the gantt view: (still don't know how to reference uploaded images here)
Poster
Owner

I think that's something that affects the sidebar in the task list view as well?

I think that's something that affects the sidebar in the task list view as well?
Collaborator

Possible!

Possible!
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.