vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: currentPage of pagination component is undefined #1002

Merged
konrad merged 2 commits from fix/current-page-undefined into main 2021-11-14 21:06:26 +00:00
Conversation 3 Commits 2 Files Changed 1 +1 -1
konrad commented 2021-11-14 20:25:18 +00:00
Owner
Copy Link

This PR fixes the following error when opening list views (List or Table):

Invalid prop: type check failed for prop "currentPage". Expected Number with value NaN, got Undefined

The prop value is coming from a mixin and I'm suspecting the mixin is not yet available when the pagination component gets mounted into the page.

This PR fixes the following error when opening list views (List or Table): ``` Invalid prop: type check failed for prop "currentPage". Expected Number with value NaN, got Undefined ``` The prop value is coming from a mixin and I'm suspecting the mixin is not yet available when the pagination component gets mounted into the page.
konrad added 1 commit 2021-11-14 20:25:18 +00:00
continuous-integration/drone/pr Build is passing Details
c3e8808edf
fix: currentPage of pagination component is undefined
konrad requested review from dpschen 2021-11-14 20:25:25 +00:00
frederick commented 2021-11-14 20:29:03 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1002-fixcurrent-page-undefined--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1002-fixcurrent-page-undefined--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2021-11-14 20:41:18 +00:00
Member
Copy Link

It feels like either currentPage should never be undefined or the prop of the pagination component shold not be required and instead default to 0.

It feels like either currentPage should never be undefined or the prop of the pagination component shold not be required and instead default to `0`.
konrad added 1 commit 2021-11-14 20:51:29 +00:00
konrad commented 2021-11-14 20:51:54 +00:00
Author
Owner
Copy Link

It feels like either currentPage should never be undefined or the prop of the pagination component shold not be required and instead default to 0.

I think that makes more sense. Refactored to set it to 0 by default.

> It feels like either currentPage should never be undefined or the prop of the pagination component shold not be required and instead default to 0. I think that makes more sense. Refactored to set it to `0` by default.
👍 1
dpschen approved these changes 2021-11-14 20:54:56 +00:00
konrad merged commit 6c6ccc647e into main 2021-11-14 21:06:26 +00:00
konrad deleted branch fix/current-page-undefined 2021-11-14 21:06:27 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1002
No description provided.
Delete Branch "fix/current-page-undefined"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?