fix(dark mode): dark mode adjustments #1069

Merged
konrad merged 3 commits from fix/dark-mode into main 2021-11-23 21:20:51 +00:00
Owner

Partly resolves #1063

Partly resolves #1063
konrad added 3 commits 2021-11-23 20:57:10 +00:00
konrad requested review from dpschen 2021-11-23 20:57:17 +00:00
Author
Owner

Ping @dpschen @adrinux

Ping @dpschen @adrinux
konrad reviewed 2021-11-23 20:58:48 +00:00
@ -77,3 +77,3 @@
--logo-text-color: hsl(180, 1%, 15%);
--link: var(--primary);
Author
Owner

I've noticed that variable was not defined so I figured I might just set it. Even if it should probably be set by bulma directly?

I've noticed that variable was not defined so I figured I might just set it. Even if it should probably be set by bulma directly?
Contributor

Yes, noticed that too. It should be. It's in the Bulma CSS, but I'm not clear how it's set in Bulma Sass - maybe a bug in Bulma-css-variables sass?

Yes, noticed that too. It should be. It's in the Bulma CSS, but I'm not clear how it's set in Bulma Sass - maybe a bug in Bulma-css-variables sass?
Author
Owner

Looks like it. Maybe a case for #1064?

Looks like it. Maybe a case for #1064?
Contributor

We probably want to change it to primary anyway, instead of bulma default blue, so that's all good. But that fact it's not picking it up from bulma is wrong.

We probably want to change it to primary anyway, instead of bulma default blue, so that's all good. But that fact it's not picking it up from bulma is wrong.
Contributor

Looks like it. Maybe a case for #1064?

Maybe. I'll take a stab at #1064.

> Looks like it. Maybe a case for #1064? Maybe. I'll take a stab at #1064.
Member

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1069-fixdark-mode--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1069-fixdark-mode--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Contributor

See my comment #1063 (comment)

I think something basic isn't right - though not sure if that's causing these issues or these are edge cases. Possibly a mix of both.

See my comment https://kolaente.dev/vikunja/frontend/issues/1063#issuecomment-20111 I think something basic isn't right - though not sure if that's causing these issues or these are edge cases. Possibly a mix of both.
dpschen approved these changes 2021-11-23 21:19:52 +00:00
konrad merged commit 6cde8e2640 into main 2021-11-23 21:20:51 +00:00
konrad deleted branch fix/dark-mode 2021-11-23 21:20:51 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.