WIP: ARCHIVE team views #1098

Closed
dpschen wants to merge 1 commits from dpschen/frontend:feature/use-script-setup-for-team-views into main
Member

This is really super WIP.

I just wanted to share this since this was the branch where I experimented with Pinia. Not sure if the way I use it here makes any sense =)

This is really super WIP. I just wanted to share this since this was the branch where I experimented with Pinia. Not sure if the way I use it here makes any sense =)
dpschen force-pushed feature/use-script-setup-for-team-views from 9dada24721 to 04aa74a01f 2021-11-28 12:47:43 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1098-featureuse-script-setup-for-team-views--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1098-featureuse-script-setup-for-team-views--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Author
Member

I found https://harlemjs.com/
This seems to be a really nice alternative to pinia.

I didn't test it yet but from the first look I prefer the api over the one of pinia.
For example: the state is immutable from outside mutations.

There is a discussion about a strict option in pinia but there seems to be no progress. The author thinks it would be best to solve this on a linter level. I can understand the reasoning behind this, but since there is no linting plugin (for over a year now), this seems to be of no priority for the author.

For me this is a deal breaker!
I'm sure that a huge part of the really nasty bugs we have / had are caused by modifications of the store state outside of mutations.

I found https://harlemjs.com/ This seems to be a really nice alternative to pinia. I didn't test it yet but from the first look I prefer the api over the one of pinia. For example: the state is immutable from outside mutations. There is a discussion about a `strict` option in pinia but there seems to be no progress. The author thinks it would be best to solve this on a linter level. I can understand the reasoning behind this, but since there is no linting plugin (for over a year now), this seems to be of no priority for the author. For me this is a deal breaker! I'm sure that a huge part of the really nasty bugs we have / had are caused by modifications of the store state outside of mutations.
dpschen self-assigned this 2022-09-29 09:02:39 +00:00
Author
Member

@konrad
Now that pinia is merged, I'll redo this and copy over the stuff from here that is good.
There were some improvements to the team managments.

@konrad Now that pinia is merged, I'll redo this and copy over the stuff from here that is good. There were some improvements to the team managments.
dpschen changed title from WIP: feat: use script setup for team views WIP to WIP: ARCHIVE team views 2022-10-31 19:25:38 +00:00
Owner

Closing this as it appears stale.

Please rebase and reopen if you think this is still relevant.

Closing this as it appears stale. Please rebase and reopen if you think this is still relevant.
konrad closed this pull request 2023-10-22 17:39:36 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.