Redefine all Bulma variables to fix undefined variables #1165
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
4 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1165
Loading…
Reference in New Issue
No description provided.
Delete Branch "adrinux/frontend:set-all-variables"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As per discussion in #1074
This will hopefully eventually be fixed at the root - with missing scss variables properly passed though, possibly by switching to Bulvar.
But in the mean time I experimented with add ALL the bulma css color related variables into color.scss
This fixes the issue with the date picker in light mode. Also has me wondering if it will allow removal of some of other little overrides we made to fix niggling issues with dark mode, so marking this WIP.
Not suggesting this ever be merged, just exploring.
Resolves #1497
Resolves #1074
If this is merged, I think it would superseed #1079?
Hi adrinux!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1165-set-all-variables--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
Well, yes and no.
This brings back the default Bulma values for --text etc which apply in light mode and are overriden in dark mode.
But #1079 uses vikunja specific shades of grey for --text etc in light mode.
Both fix #1074 but #1079 is a design choice too. Probably need some side by side screenshots to be clear what the difference is.
EDIT: I'm making screenshots
Here's combined screenshots of #1079 (left) and this PR #1165 (right) - if there is a difference in text colour
it's imperceptible.EDIT: On closer inspection some titles (Hi demo!, Last Viewed and Current Tasks for example) have much darker text in #1079 vs #1165 and in general text is darker in #1079.
Most obvious difference here is that the list card link text gains --link colour in this PR. In #1079 and I think main, it's overriden by a scoped --title colour. It is grey in the current release too because its span element.
So this approach may cause problems as well as fix them.EDIT: Between the existing release and current head of the main branch the list card html changed from 'span' to 'a' - it should have link colour.
I'm fine merging this and closing the other one. I made a design choice in the other PR yes but didn't put much though in it.
We should change the color of the list cards though, since that's also broken right now. Could be another PR.
It would at least let things move forward. And they're easy enough to remove when the underlying problem gets sorted.
I'll tidy up some the comments a bit.
Back to the normal text colour?
Absolutely.
Yeah exactly. The same way they look like in the current stable version.
Looks like that's already fixed, will remove the WIP prefix.
WIP: Redefine all Bulma variables to fix undefined variablesto Redefine all Bulma variables to fix undefined variables@dpschen I think we should merge this, anything to add?
Sry, lots to do! Trying to get to this as soon as possible!
@dpschen Anything to add?
Thanks! Sorry it took so long to merge.