vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: use blurHash when loading list backgrounds #1188

Merged
konrad merged 13 commits from feature/blur-hash into main 2022-04-02 15:05:31 +00:00
Conversation 3 Commits 13 Files Changed 13 +387 -234
konrad commented 2021-12-12 21:32:18 +00:00
Owner
Copy Link

Frontend for vikunja/api#1066

Things left to do:

  • Figure out a good way to let the real image "fade in" - probably requires putting a second <img/> tag over the background?
Frontend for https://kolaente.dev/vikunja/api/pulls/1066 Things left to do: * [x] Figure out a good way to let the real image "fade in" - probably requires putting a second `<img/>` tag over the background?
konrad added 2 commits 2021-12-12 21:32:19 +00:00
continuous-integration/drone/pr Build is failing Details
b5f693e230
feat: use blurHash when loading list backgrounds
konrad added 1 commit 2021-12-20 18:44:41 +00:00
continuous-integration/drone/pr Build is failing Details
af177071d6
Merge branch 'main' into feature/blur-hash 
# Conflicts:
#	package.json
konrad added 1 commit 2021-12-20 20:36:44 +00:00
continuous-integration/drone/pr Build is failing Details
daf3212902
feat: add fade in for background images
konrad added 1 commit 2021-12-20 21:04:04 +00:00
continuous-integration/drone/pr Build is failing Details
0e886ba76b
feat: add blurHash loading for list cards
konrad added 1 commit 2021-12-20 21:06:48 +00:00
continuous-integration/drone/pr Build is failing Details
33158167d5
chore: make background fade in reusable
konrad added 1 commit 2021-12-20 21:08:23 +00:00
continuous-integration/drone/pr Build is failing Details
b85df38245
fix: lint
frederick commented 2021-12-20 21:11:31 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1188-featureblur-hash--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1188-featureblur-hash--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad changed title from WIP: feat: use blurHash when loading list backgrounds to feat: use blurHash when loading list backgrounds 2021-12-20 21:11:55 +00:00
konrad commented 2021-12-20 21:13:52 +00:00
Author
Owner
Copy Link

I think this is ready now, but I'm not quite sure about the performance implications of it yet.

Also the fade in works, but only when switching from a list (or any other page) without a background to one with a background. This seems to be because the is-visible property I added to the actual list background is not removed while switching between lists.

I think this is ready now, but I'm not quite sure about the performance implications of it yet. Also the fade in works, but only when switching from a list (or any other page) without a background to one with a background. This seems to be because the `is-visible` property I added to the actual list background is not removed while switching between lists.
konrad commented 2021-12-20 21:19:03 +00:00
Author
Owner
Copy Link

Looks like the performance is mostly fine, just not with the local dev build. And on main as well, so nothing related to this PR.

Looks like the performance is mostly fine, just not with the local dev build. And on main as well, so nothing related to this PR.
konrad reviewed 2021-12-20 21:20:16 +00:00
src/styles/theme/background.scss
@ -37,0 +48,4 @@
.background-fade-in {
opacity: 0;
transition: opacity $transition;
konrad commented 2021-12-20 21:20:16 +00:00
Author
Owner

I'm not quite sure why <transition> did not work here.

I'm not quite sure why `<transition>` did not work here.
konrad requested review from dpschen 2021-12-20 21:21:31 +00:00
dpschen was assigned by konrad 2021-12-20 21:21:36 +00:00
konrad added 1 commit 2022-01-08 12:52:07 +00:00
continuous-integration/drone/pr Build is failing Details
bfb356eb8b
Merge branch 'main' into feature/blur-hash 
# Conflicts:
#	package.json
#	src/components/home/contentAuth.vue
konrad added 1 commit 2022-01-16 17:35:30 +00:00
continuous-integration/drone/pr Build is failing Details
e79715faa8
Merge branch 'main' into feature/blur-hash
konrad added 2 commits 2022-04-02 12:38:57 +00:00
f8ca1c47a9
Merge branch 'main' into feature/blur-hash 
# Conflicts:
#	package.json
#	src/components/home/contentAuth.vue
#	src/store/index.js
#	src/views/list/ShowList.vue
continuous-integration/drone/pr Build is failing Details
7ff8daf6e2
fix: top navigation not usable
konrad added 2 commits 2022-04-02 13:13:24 +00:00
konrad merged commit 4cff3ebee1 into main 2022-04-02 15:05:31 +00:00
konrad deleted branch feature/blur-hash 2022-04-02 15:05:31 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1188
No description provided.
Delete Branch "feature/blur-hash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?