fix: load the list tasks only after the list itself was loaded #1251
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1251
Loading…
Reference in New Issue
No description provided.
Delete Branch "fix/load-list-first"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently, when opening a list sometimes the tasks are shown before the list itself is loaded. Because the list contains the rights, this means no edit buttons etc are available at that point which is pretty confusing.
This PR ensures the list-specific view is loaded only after the list itself is loaded.
@ -147,0 +150,4 @@const listFromStore = this.$store.getters['lists/getListById'](listData.id)if (listFromStore !== null) {this.$store.commit(BACKGROUND, null)this.$store.commit(CURRENT_LIST, listFromStore)I feel like I did this before in some other PR?
@dpschen Will this conflict with #816?
Maybe a better idea would be to hide the list-specific view with css instead of using
v-if? That way the list view could maybe already start loading everything it needs?Hi konrad!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1251-fixload-list-first--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
Let's wait with this until #816 is merged.
@konrad Does this still make sense, now that #816 is merged?
@dpschen I think it does. The issue I initially set out to solve with this PR is still present.