WIP: fix: don't try to load a task view with the id of the list #1252

konrad · 2021-12-26T18:05:45Z

konrad commented

2021-12-26 18:05:45 +00:00

No description provided.

konrad added 1 commit 2021-12-26 18:05:45 +00:00

continuous-integration/drone/pr Build is passing Details

75c82d010b

fix: don't try to load a task view with the id of the list

konrad reviewed 2021-12-26 18:06:17 +00:00

src/views/tasks/TaskDetailView.vue

						
				@ -527,1 +531,4 @@

								return undefined

							}

							const {id} = this.$route.params

konrad commented

2021-12-26 18:06:17 +00:00

Maybe a better fix would be to rename the param in the router config to something like taskId?

Maybe a better fix would be to rename the param in the router config to something like `taskId`?

dpschen commented

2022-01-04 20:19:55 +00:00

Yes that makes sense. I do actually already the opposite in the modal branch:
I renamed the list id param in listId. E.g. 43c935ca41/src/router/index.ts (L263)

Yes that makes sense. I do actually already the opposite in the modal branch: I renamed the list id param in `listId`. E.g. https://kolaente.dev/dpschen/frontend/src/commit/43c935ca4141de6f85bb22c959b730a4e7d04854/src/router/index.ts#L263

konrad commented

2022-01-05 14:28:44 +00:00

So this PR will probably get obsolete once we merge the modal one?

dpschen commented

2022-01-05 14:51:12 +00:00

I think so, yes

👍 1

konrad commented

2022-01-05 16:48:31 +00:00

Okay, I'll set this to wip until the other one is merged so we don't accedentially merge this.

👍 1

frederick commented

2021-12-26 18:11:07 +00:00

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1252-fixload-task-as-list--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1252-fixload-task-as-list--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad changed title from ~~fix: don't try to load a task view with the id of the list~~ to WIP: fix: don't try to load a task view with the id of the list

2022-01-05 16:48:36 +00:00

dpschen commented

2022-02-06 15:12:31 +00:00

@konrad I think this can be closed now that the modal branch is merged.