vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: replace jest with vitest #1277

Merged
dpschen merged 1 commits from dpschen/frontend:feature/feat-replace-jest-with-vitest into main 2022-01-04 13:35:09 +00:00
Conversation 1 Commits 1 Files Changed 14 +323 -1406
dpschen commented 2022-01-01 13:26:12 +00:00
Member
Copy Link
No description provided.
dpschen added the
kind/feature
 label 2022-01-01 13:26:12 +00:00
konrad was assigned by dpschen 2022-01-01 13:26:12 +00:00
dpschen reviewed 2022-01-01 13:26:49 +00:00
src/modules/parseTaskText.test.js Outdated
@ -201,19 +203,19 @@ describe('Parse Task Text', () => {
expect(`${result.date.getFullYear()}-${result.date.getMonth()}-${result.date.getDate()}`).toBe(`${nextThursday.getFullYear()}-${nextThursday.getMonth()}-${nextThursday.getDate()}`)
expect(`${result.date.getHours()}:${result.date.getMinutes()}`).toBe('14:0')
})
it('should recognize dates of the month in the past but next month', () => {
dpschen commented 2022-01-01 13:26:49 +00:00
Author
Member

I just commited this out for now. Fix should happen in a different pull request

I just commited this out for now. Fix should happen in a different pull request
dpschen marked this conversation as resolved
frederick commented 2022-01-01 13:28:26 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1277-featurefeat-replace-jest-with-vitest--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1277-featurefeat-replace-jest-with-vitest--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/feat-replace-jest-with-vitest from e236980e15 to 6a9a16f0b1 2022-01-01 13:41:30 +00:00 Compare
dpschen requested review from konrad 2022-01-01 13:42:44 +00:00
dpschen force-pushed feature/feat-replace-jest-with-vitest from 6a9a16f0b1 to c42b9174c8 2022-01-01 13:47:24 +00:00 Compare
konrad reviewed 2022-01-01 15:48:14 +00:00
vite.config.ts Outdated
@ -0,0 +30,4 @@
export default defineConfig({
// https://vitest.dev/config/
test: {
environment: 'happy-dom',
konrad commented 2022-01-01 15:48:14 +00:00
Owner

What is this good for?

What is this good for?
dpschen commented 2022-01-01 15:49:55 +00:00
Author
Member

Is needed so that we can use DOM features in vitest, see https://vitest.dev/config/#environment

Needed for src/modules/listHistory.test.ts

Is needed so that we can use DOM features in vitest, see https://vitest.dev/config/#environment Needed for `src/modules/listHistory.test.ts`
👍 1
konrad marked this conversation as resolved
konrad reviewed 2022-01-01 15:49:03 +00:00
src/modules/parseTaskText.test.js Outdated
@ -202,3 +204,3 @@
expect(`${result.date.getHours()}:${result.date.getMinutes()}`).toBe('14:0')
})
it('should recognize dates of the month in the past but next month', () => {
it.skip('should recognize dates of the month in the past but next month', () => {
konrad commented 2022-01-01 15:49:03 +00:00
Owner

Can we add a message why it is skipped?

Can we add a message why it is skipped?
dpschen commented 2022-01-01 15:50:37 +00:00
Author
Member

I just skipped it because it's failing :D
But we should fix it. I just don't understand what it should do => can't fix.

I just skipped it because it's failing :D But we should fix it. I just don't understand what it should do => can't fix.
dpschen force-pushed feature/feat-replace-jest-with-vitest from c42b9174c8 to 771a6e4393 2022-01-03 15:29:47 +00:00 Compare
dpschen force-pushed feature/feat-replace-jest-with-vitest from 771a6e4393 to 0026b6e3bd 2022-01-03 15:44:23 +00:00 Compare
dpschen force-pushed feature/feat-replace-jest-with-vitest from 0026b6e3bd to 31cb30109f 2022-01-03 15:45:55 +00:00 Compare
konrad approved these changes 2022-01-03 21:18:27 +00:00
konrad left a comment
Owner

Should be good to merge once the conflicts are resolved :

Should be good to merge once the conflicts are resolved :
dpschen force-pushed feature/feat-replace-jest-with-vitest from 31cb30109f to 8114012997 2022-01-04 13:16:59 +00:00 Compare
dpschen merged commit 8114012997 into main 2022-01-04 13:35:09 +00:00
dpschen deleted branch feature/feat-replace-jest-with-vitest 2022-01-04 13:35:09 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1277
No description provided.
Delete Branch "dpschen/frontend:feature/feat-replace-jest-with-vitest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?