feat: run vue-tsc in ci #1295

dpschen · 2022-01-04T17:03:08Z

dpschen commented

2022-01-04 17:03:08 +00:00

We had this in for a while already, but never cared for the result.
Might make sense to integrate in the pipeline.

To make things easy from the start we could add failure: ignore to the step

We had this in for a while already, but never cared for the result. Might make sense to integrate in the pipeline. To make things easy from the start we could add [`failure: ignore`](https://docs.drone.io/pipeline/macstadium/syntax/steps/#failure) to the step

dpschen added the

kind/feature

label 2022-01-04 17:03:08 +00:00

konrad was assigned by dpschen

2022-01-04 17:03:08 +00:00

dpschen force-pushed feature/feat-run-vue-tsc-in-ci from 91de1adaad to dc1c4387f1

2022-01-04 17:04:56 +00:00

Compare

dpschen force-pushed feature/feat-run-vue-tsc-in-ci from dc1c4387f1 to 359ef33b46

2022-01-04 17:05:47 +00:00

Compare

dpschen force-pushed feature/feat-run-vue-tsc-in-ci from 359ef33b46 to 2143523b5a

2022-01-04 17:07:02 +00:00

Compare

dpschen requested review from konrad 2022-01-04 18:18:12 +00:00

dpschen force-pushed feature/feat-run-vue-tsc-in-ci from 2143523b5a to 16f4b00366

2022-01-04 18:45:34 +00:00

Compare

dpschen referenced this pull request

2022-01-05 10:06:55 +00:00

fix: remove some of the typescript warnings #1304

konrad approved these changes 2022-01-05 12:28:03 +00:00

konrad commented

2022-01-05 12:28:56 +00:00

I'm wondering a bit why there's no CI run for this commit

dpschen commented

2022-01-05 12:32:13 +00:00

Should I add the failure: ignore?

Should I add the `failure: ignore`?

konrad commented

2022-01-05 13:02:43 +00:00

Should I add the failure: ignore?

I don't think that's related, there isn't even a failing CI run here. Just nothing.

Maybe there's something in the drone logs.

> Should I add the failure: ignore? I don't think that's related, there isn't even a failing CI run here. Just nothing. Maybe there's something in the drone logs.

konrad commented

2022-01-05 13:06:40 +00:00

Ah so it looks like the drone config is broken:

{
  "commit": "3099280c9c3454ba6936f136a94bd6c4a54eecaf",
  "error": "yaml: line 99: did not find expected key",
  "event": "pull_request",
  "level": "warning",
  "msg": "trigger: cannot parse yaml",
  "ref": "refs/pull/1295/head",
  "repo": "vikunja/frontend",
  "time": "2022-01-05T13:03:24Z"
}

Very interesting drone doesn't even report that as a failing step though.

Ah so it looks like the drone config is broken: ``` { "commit": "3099280c9c3454ba6936f136a94bd6c4a54eecaf", "error": "yaml: line 99: did not find expected key", "event": "pull_request", "level": "warning", "msg": "trigger: cannot parse yaml", "ref": "refs/pull/1295/head", "repo": "vikunja/frontend", "time": "2022-01-05T13:03:24Z" } ``` Very interesting drone doesn't even report that as a failing step though.

konrad commented

2022-01-05 13:07:55 +00:00

@dpschen Can you check and fix the config with drone lint from the drone cli?

@dpschen Can you check and fix the config with `drone lint` from the [drone cli](https://docs.drone.io/cli/install/)?

👍 1

konrad requested changes 2022-01-05 14:22:29 +00:00

konrad left a comment

Please fix the drone config.

dpschen force-pushed feature/feat-run-vue-tsc-in-ci from 3099280c9c to 0e59130c03

2022-01-05 15:15:29 +00:00

Compare

konrad commented

2022-01-05 16:47:45 +00:00

Now we have a failing step :) https://drone.kolaente.de/vikunja/frontend/6416/1/7

I think adding failure: ignore should be fine for now, if you feel like it you could also fix all the warnings so the step passes (we should do this at some point anyway).

Now we have a failing step :) https://drone.kolaente.de/vikunja/frontend/6416/1/7 I think adding `failure: ignore` should be fine for now, if you feel like it you could also fix all the warnings so the step passes (we should do this at some point anyway).

🎉 1

dpschen force-pushed feature/feat-run-vue-tsc-in-ci from 0e59130c03 to 89cb241bc8

2022-01-05 19:58:12 +00:00

Compare

frederick commented

2022-01-05 20:01:59 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1295-featurefeat-run-vue-tsc-in-ci--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1295-featurefeat-run-vue-tsc-in-ci--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen requested review from konrad 2022-01-05 21:03:00 +00:00

dpschen commented

2022-01-05 21:03:43 +00:00

I think adding failure: ignore should be fine for now, if you feel like it you could also fix all the warnings so the step passes (we should do this at some point anyway).

Let's do that after the modal branch (I know it's getting a lot :D )

> I think adding failure: ignore should be fine for now, if you feel like it you could also fix all the warnings so the step passes (we should do this at some point anyway). Let's do that after the modal branch (I know it's getting a lot :D )

👍 1

dpschen referenced this pull request

2022-01-05 21:05:16 +00:00

Fix typecheck warnings and remove `failure ignore` from drone step #1895

konrad approved these changes 2022-01-06 10:37:31 +00:00

konrad merged commit 9b85817ddb into main

2022-01-06 10:37:52 +00:00

konrad deleted branch feature/feat-run-vue-tsc-in-ci

2022-01-06 10:37:52 +00:00

konrad referenced this issue from a commit

2022-01-06 10:37:52 +00:00

feat: run vue-tsc in ci (#1295)