vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: Make today really today. #1378

Closed
kergma-lw wants to merge 1 commits from kergma-lw/frontend:main into main
pull from: kergma-lw/frontend:main
merge into: vikunja:main
Conversation 6 Commits 1 Files Changed 1 +3 -2
kergma-lw commented 2022-01-14 16:20:41 +00:00
First-time contributor
Copy Link
No description provided.
kergma-lw added 1 commit 2022-01-14 16:20:41 +00:00
continuous-integration/drone/pr Build is passing Details
ebe4e9fe3c Make today really today.
frederick commented 2022-01-14 16:23:26 +00:00
Member
Copy Link

Hi kergma-lw!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1378-main--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi kergma-lw! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1378-main--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2022-01-14 17:20:28 +00:00
Owner
Copy Link

Thanks for the PR!

This will likely conflict with #1261 and #1342. Would you mind rebasing your changes onto one of these?

Thanks for the PR! This will likely conflict with https://kolaente.dev/vikunja/frontend/pulls/1261 and #1342. Would you mind rebasing your changes onto one of these?
kergma-lw commented 2022-01-15 08:23:53 +00:00
Author
First-time contributor
Copy Link

Thanks for the PR!

This will likely conflict with #1261 and #1342. Would you mind rebasing your changes onto one of these?

Sorry for strange PR #1380. I switch to branch fix/upcoming in my fork, commit my changes, pushed and make PR into your branch fix/upcoming. I cannot understand why so many commits in it.

> Thanks for the PR! > > This will likely conflict with https://kolaente.dev/vikunja/frontend/pulls/1261 and #1342. Would you mind rebasing your changes onto one of these? Sorry for strange PR #1380. I switch to branch fix/upcoming in my fork, commit my changes, pushed and make PR into your branch fix/upcoming. I cannot understand why so many commits in it.
konrad commented 2022-01-15 20:26:18 +00:00
Owner
Copy Link

No worries, the number of commit comes because the other PR is not yet merged into main. Hence it shows all commits from that branch and the other one, not only yours.

No worries, the number of commit comes because the other PR is not yet merged into main. Hence it shows all commits from that branch and the other one, not only yours.
konrad commented 2022-03-30 16:37:29 +00:00
Owner
Copy Link

@kergma-lw Since the date math now landed, would you mind rebasing this PR on top of the latest changes?

@kergma-lw Since the date math now landed, would you mind rebasing this PR on top of the latest changes?
dpschen reviewed 2022-04-23 12:30:56 +00:00
src/views/tasks/ShowTasks.vue
@ -249,2 +249,3 @@
this.cStartDate = new Date()
this.cEndDate = new Date(d.setDate(d.getDate() + 1))
this.cEndDate = new Date(d.setDate(d.getDate()))
this.cEndDate.setHours(23,59,0,0)
dpschen commented 2022-04-23 12:30:56 +00:00
Member

Not sure, but shouldn't this be:

this.cEndDate.setHours(23,59,59,999)

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setHours#parameters

Not sure, but shouldn't this be: ```js this.cEndDate.setHours(23,59,59,999) ``` See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setHours#parameters
konrad commented 2023-10-22 17:40:06 +00:00
Owner
Copy Link

Closing this as it appears stale.

Please rebase and reopen if you think this is still relevant.

Closing this as it appears stale. Please rebase and reopen if you think this is still relevant.
konrad closed this pull request 2023-10-22 17:40:11 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1378
No description provided.
Delete Branch "kergma-lw/frontend:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?