feature/a11y #1390

konrad · 2022-01-16T17:33:51Z

konrad commented

2022-01-16 17:33:51 +00:00

This PR improves a11y in some parts of Vikunja. I'm sure I've missed a few things, but this is definitely a start.

We should change the modal component so it behaves like a dialoge (focus trap, <dialoge> tag) in a separate PR.

This PR improves a11y in some parts of Vikunja. I'm sure I've missed a few things, but this is definitely a start. We should change the modal component so it behaves like a dialoge (focus trap, `<dialoge>` tag) in a separate PR.

frederick commented

2022-01-16 17:36:40 +00:00

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1390-featurea11y--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1390-featurea11y--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad commented

2022-01-17 08:42:42 +00:00

I have no idea what the issue is with that testing pipeline

konrad force-pushed feature/a11y from 5805c186ca to 4a846f424c

2022-01-18 20:00:44 +00:00

Compare

konrad commented

2022-01-18 20:17:53 +00:00

According to git bisect the failing test is caused by b0aa54997f - now on to figure out which change in that commit was it

According to git bisect the failing test is caused by b0aa54997fd05826f6eb1a5a355dd8879d41330d - now on to figure out which change in that commit was it

konrad added 1 commit 2022-01-18 20:28:05 +00:00

continuous-integration/drone/pr Build is passing Details

6f02d4bbac

fix: don't try to format invalid dates as ISO

konrad commented

2022-01-18 20:28:15 +00:00

Here we go 6f02d4bbac

Here we go https://kolaente.dev/vikunja/frontend/commit/6f02d4bbac7d5399f86f5c4fb79b0ae2866645d2

konrad commented

2022-01-18 20:43:12 +00:00

Tests pass, merging...

konrad merged commit 50c3bcd793 into main

2022-01-18 20:43:53 +00:00

konrad deleted branch feature/a11y

2022-01-18 20:43:53 +00:00

dpschen reviewed 2022-01-19 19:58:20 +00:00

src/components/tasks/partials/singleTaskInList.vue

						
				@ -44,3 +46,4 @@

								@click.prevent.stop="showDefer = !showDefer"

								v-if="+new Date(task.dueDate) > 0"

								v-tooltip="formatDate(task.dueDate)"

								:aria-expanded="showDefer ? 'true' : 'false'"