vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: direct store manipulation in tasks #1534

Merged
konrad merged 1 commits from dpschen/frontend:feature/fix-direct-store-manipulation-in-tasks into main 2022-02-18 19:48:50 +00:00
Conversation 1 Commits 1 Files Changed 1 +36 -30
dpschen commented 2022-02-13 15:26:56 +00:00
Member
Copy Link
No description provided.
frederick commented 2022-02-13 15:29:23 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1534-featurefix-direct-store-manipulation-in-tasks--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1534-featurefix-direct-store-manipulation-in-tasks--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen requested review from konrad 2022-02-13 15:40:50 +00:00
konrad was assigned by dpschen 2022-02-13 15:40:54 +00:00
konrad reviewed 2022-02-13 22:00:32 +00:00
src/store/modules/tasks.js Outdated
@ -160,3 +166,1 @@
break
}
}
const assignees = t.task.assignees.filter(({id}) => id === user.id)
konrad commented 2022-02-13 22:00:32 +00:00
Owner

Shouldn't this filter out all users who are not the passed user?

Shouldn't this filter out all users who are not the passed user?
dpschen commented 2022-02-13 22:10:29 +00:00
Author
Member

Indeed!
Seems like there was a reason why I didn't merge this yet :D
Will fix... (in all places)

Indeed! Seems like there was a reason why I didn't merge this yet :D Will fix... (in all places)
dpschen commented 2022-02-14 10:04:44 +00:00
Author
Member

fixed

fixed
dpschen marked this conversation as resolved
konrad reviewed 2022-02-13 22:00:48 +00:00
src/store/modules/tasks.js Outdated
@ -216,3 +224,1 @@
break
}
}
const labels = t.task.labels.filter(({id}) => id === label.id)
konrad commented 2022-02-13 22:00:48 +00:00
Owner

Same here

Same here
dpschen commented 2022-02-14 10:04:55 +00:00
Author
Member

fixed

fixed
dpschen marked this conversation as resolved
dpschen force-pushed feature/fix-direct-store-manipulation-in-tasks from a63a94573f to ba477e8a3b 2022-02-13 22:19:56 +00:00 Compare
konrad approved these changes 2022-02-18 19:48:45 +00:00
konrad merged commit c419062e49 into main 2022-02-18 19:48:50 +00:00
konrad deleted branch feature/fix-direct-store-manipulation-in-tasks 2022-02-18 19:48:50 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1534
No description provided.
Delete Branch "dpschen/frontend:feature/fix-direct-store-manipulation-in-tasks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?