WIP: feat: create KanbanBucket from ListKanban #1571
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1571
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/feat-kanban-bucket-component"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
By removing the bucket form ListKanban we can reduce the complexity a lot.
This is still work-in-progress. Most stuff should work.This might currently not work, but mostly because a small rebase is needed.
The biggest open task is migrating the saveCollapsedBucketState.
=> will solve this in a future pull request
TODO:
@ -0,0 +16,4 @@
const MIN_SCROLL_HEIGHT_PERCENT = 0.25
const props = defineProps<{
bucketIndex: number
number
orNumber
? (What is the difference between them?)number
is the Typescript type of number, whileNumber
is a primitive object wrapper.See: https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html#number-string-boolean-symbol-and-object
@ -0,0 +17,4 @@
const props = defineProps<{
bucketIndex: number
isCollapsed: boolean
Does this need to be a prop? Since we now have everything bucket-related in a single component, shouldn't it be enough to use a ref?
Yes and no. Since we currently save the collapsed state of the whole list, when a bucket collapses we need to change that in order to make this bucket specific. I'm still working on this, this is one of the reasosn this is still WIP.
If we want to let's refactor this in a future pull request.
Want to keep this pull request as simple as possible.
Main target was to separate KanbanBucket from ListKanban
@ -0,0 +24,4 @@
dragOptions: Object
params: Object
shouldAcceptDrop: boolean
isDraggingTask: boolean
Does this need to be a prop?
Will check
Maybe. But let's go the same way as with #1571 (comment)
@ -0,0 +164,4 @@
}
</script>
<template>
Could you add the
<template>
before the<script>
? Just to keep it consistent.I was following here the new recommended order. See https://eslint.vuejs.org/rules/component-tags-order.html
When we enable the new settings this will change everywhere.
Doesn't the doc you linked say switching
<template>
and<script>
blocks as long as the<style>
tag comes last is allowed?Fromt reading it seems like it, strange!
Because when I ran #930 this reordering was applied automatically.
I will change it back for this pull request. If #930 changes it we'll handle it there.
@ -621,1 +315,4 @@
}
</style>
<style lang="scss">
Please merge the two
<style>
tags since they are the same@ -773,2 +370,2 @@
}
}
.new-bucket {
// Because of reasons, this button ignores the margin we gave it to the right.
Now that I read that comment again, I feel like this might have something to do with margin collapse...
I will recheck the styles =)
Let's do this in an additional pull request. I want to refactor all these components either way. For now I just wanted to separate the logic. Makes future steps simpler.
940938c65a
to4f25e18c38
WIP: feat: create KanbanBucket from ListKanbanto feat: create KanbanBucket from ListKanban4f25e18c38
to7886515193
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1571-feature-feat-kanban-bucket-compo--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
7e963d3c8e
todfe3356df3
This is currently out of date, but was working already.
I'm not sure if I should update this if we don't merge it then?
I think this would be a good thing to have. If you want to continue working on this, I'd appreciate a rebase.
dfe3356df3
to244b5318c1
244b5318c1
to0750839e64
0750839e64
tod6970bdd6d
Trying to do anything on the kanban board returns this error:
feat: create KanbanBucket from ListKanbanto WIP: feat: create KanbanBucket from ListKanbanYes, sry this was working once, but I need to make it work again. I rebased it to get a better understanding of the diff. But it's not yet functional again.
Closing this as it appears stale.
Please rebase and reopen if you think this is still relevant.