WIP: feat: #1585 redeploy Netlify preview on push #1586

Closed
dpschen wants to merge 2 commits from dpschen:feature/feat-1585-redeploy-netlify-preview-on-push into main
Member

See: #1585

See: https://kolaente.dev/vikunja/frontend/issues/1585
dpschen added 1 commit 2022-02-20 11:09:38 +00:00
continuous-integration/drone/pr Build is passing Details
0ccfeb0daa
feat: #1585 redeploy Netlify preview on push
Owner

But the preview is already updated every time the PR is updated? There just isn't a new comment from the bot to reduce the noise.

But the preview is already updated every time the PR is updated? There just isn't a new comment from the bot to reduce the noise.
Author
Member

It is? Maybe I had caching problems. No spam is definitely good! :D

Subsequently I'm confused what this example is for:

https://docs.drone.io/pipeline/triggers/#by-event
(under "Example include syntax:")

I have no experience with Drone. I just know that in Gitlab CI you need to combine these triggers, maybe that's different.

It is? Maybe I had caching problems. No spam is definitely good! :D Subsequently I'm confused what this example is for: https://docs.drone.io/pipeline/triggers/#by-event (under "Example include syntax:") I have no experience with Drone. I just know that in Gitlab CI you need to combine these triggers, maybe that's different.
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1586-feature-feat-1585-redeploy-netli--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1586-feature-feat-1585-redeploy-netli--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen added 1 commit 2022-02-20 11:23:18 +00:00
continuous-integration/drone/pr Build is passing Details
267aab4337
force redeploy
Author
Member

I guess my test was stupid, since I tested after changing this setting.
But at least with this setting the redeploy doesn't seem to work (there is no red background visible from 267aab4337)

I guess my test was stupid, since I tested _after_ changing this setting. But at least with this setting the redeploy doesn't seem to work (there is no red background visible from https://kolaente.dev/vikunja/frontend/commit/267aab43375daaf76be3452abb47f67041196908)
Owner

Works for me: image

Maybe yours was still cached from the last time you opened the preview deploy?

Works for me: ![image](/attachments/f0e72ebb-401f-4467-8a1a-fb37a60f5e8c) Maybe yours was still cached from the last time you opened the preview deploy?
736 KiB
Author
Member

Maybe the caching of the service worker.

Maybe the caching of the service worker.
Author
Member

I still don't really understand, why it works without the push (that's why I created the test branch), but it works :D

Closing.

I still don't really understand, why it works without the push (that's why I created the test branch), but it works :D Closing.
dpschen closed this pull request 2022-02-21 21:13:21 +00:00
dpschen deleted branch feature/feat-1585-redeploy-netlify-preview-on-push 2022-02-21 21:13:27 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.