WIP: feat: #1585 redeploy Netlify preview on push #1586
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1586
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen:feature/feat-1585-redeploy-netlify-preview-on-push"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
See: #1585
But the preview is already updated every time the PR is updated? There just isn't a new comment from the bot to reduce the noise.
It is? Maybe I had caching problems. No spam is definitely good! :D
Subsequently I'm confused what this example is for:
https://docs.drone.io/pipeline/triggers/#by-event
(under "Example include syntax:")
I have no experience with Drone. I just know that in Gitlab CI you need to combine these triggers, maybe that's different.
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1586-feature-feat-1585-redeploy-netli--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
I guess my test was stupid, since I tested after changing this setting.
But at least with this setting the redeploy doesn't seem to work (there is no red background visible from
267aab4337
)Works for me:
Maybe yours was still cached from the last time you opened the preview deploy?
Maybe the caching of the service worker.
I still don't really understand, why it works without the push (that's why I created the test branch), but it works :D
Closing.