feat: TaskDetail as script setup #1792

Merged
konrad merged 1 commits from dpschen/frontend:feature/task-detail-as-script-setup into main 2022-10-01 15:02:37 +00:00
Member

This is quite old and currently probably broken.
But I think it can still help to move the current task detail to script setup.

Rebased and now based on the final pinia branch.

~~This is quite old and currently probably broken. But I think it can still help to move the current task detail to script setup.~~ Rebased and now based on the final pinia branch.
dpschen added 1 commit 2022-04-09 19:05:27 +00:00
continuous-integration/drone/pr Build is failing Details
4cb6bc6c3b
feat: TaskDetail as script setup
dpschen force-pushed feature/task-detail-as-script-setup from 4cb6bc6c3b to 11b4bcc7ac 2022-09-29 15:19:44 +00:00 Compare
dpschen changed title from WIP: feat: TaskDetail as script setup to feat: TaskDetail as script setup 2022-09-29 15:20:39 +00:00
dpschen added the
kind/feature
help wanted
labels 2022-09-29 15:20:58 +00:00
dpschen requested review from konrad 2022-09-29 15:21:05 +00:00
dpschen force-pushed feature/task-detail-as-script-setup from 11b4bcc7ac to 2f7dca8c29 2022-09-29 15:30:31 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1792-feature-task-detail-as-script-se--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1792-feature-task-detail-as-script-se--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/task-detail-as-script-setup from 2f7dca8c29 to d21dc7a464 2022-09-29 15:38:54 +00:00 Compare
konrad was assigned by dpschen 2022-09-29 15:40:48 +00:00
Owner

So let's merge all pina PRs first?

So let's merge all pina PRs first?
Author
Member

So let's merge all pina PRs first?

Yes

> So let's merge all pina PRs first? Yes
dpschen force-pushed feature/task-detail-as-script-setup from d21dc7a464 to 1228820fe0 2022-09-29 19:46:46 +00:00 Compare
dpschen force-pushed feature/task-detail-as-script-setup from 1228820fe0 to 94db7a67ef 2022-10-01 13:39:59 +00:00 Compare
dpschen force-pushed feature/task-detail-as-script-setup from 94db7a67ef to 56459103c4 2022-10-01 14:19:51 +00:00 Compare
dpschen force-pushed feature/task-detail-as-script-setup from 56459103c4 to 0d2ec54876 2022-10-01 14:40:20 +00:00 Compare
dpschen force-pushed feature/task-detail-as-script-setup from 0d2ec54876 to f4619ab69d 2022-10-01 14:42:19 +00:00 Compare
konrad reviewed 2022-10-01 14:59:59 +00:00
@ -521,0 +509,4 @@
// updated, changed, updated and so on.
// To prevent this, we put the task color property in a seperate value which is set to the task color
// when it is saved and loaded.
const taskColor = ref<ITask['hexColor']>('')

Not sure if we even need this anymore (not using verte). But I'd leave it as is right now, maybe fix this in a follow-up

Not sure if we even need this anymore (not using verte). But I'd leave it as is right now, maybe fix this in a follow-up
konrad approved these changes 2022-10-01 15:02:21 +00:00
konrad merged commit 2dc36c032b into main 2022-10-01 15:02:37 +00:00
konrad deleted branch feature/task-detail-as-script-setup 2022-10-01 15:02:38 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.