vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: improved checkbox #1800

Merged
konrad merged 4 commits from dpschen/frontend:feature/improve-checkbox into main 2023-03-29 15:30:24 +00:00
Conversation 12 Commits 4 Files Changed 17 +244 -174
dpschen commented 2022-04-10 00:43:01 +00:00
Member
Copy Link

Still WIP.

Extending from: #1812

Still WIP. Extending from: https://kolaente.dev/vikunja/frontend/pulls/1812
😆 1
dpschen force-pushed feature/improve-checkbox from 2501c385bd to e9439a2ec2 2022-04-11 20:16:22 +00:00 Compare
dpschen added a new dependency 2022-04-11 20:18:55 +00:00
#1812 feature/feat-improve-ts-setup
dpschen force-pushed feature/improve-checkbox from e9439a2ec2 to cfeac226cf 2022-04-11 20:24:06 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from cfeac226cf to 675d366370 2022-04-11 20:38:21 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 675d366370 to c97b3d4b16 2022-04-11 20:39:51 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from c97b3d4b16 to 38ee9f5528 2022-04-11 20:53:50 +00:00 Compare
dpschen changed title from WIP: improved ts setup / better testing on the example of an improved checkbox to WIP: improved testing / with example checkbox 2022-04-11 22:08:38 +00:00
dpschen force-pushed feature/improve-checkbox from 38ee9f5528 to 5bf738ceef 2022-04-23 11:38:26 +00:00 Compare
dpschen changed title from WIP: improved testing / with example checkbox to WIP: improved checkbox 2022-06-21 22:54:45 +00:00
dpschen force-pushed feature/improve-checkbox from 5bf738ceef to e6f5c8f2b9 2022-06-21 22:57:38 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from e6f5c8f2b9 to d7ab79599e 2022-07-04 21:38:48 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from d7ab79599e to 81eaf6e2b3 2022-07-04 21:57:27 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 81eaf6e2b3 to 879a77ed88 2022-09-08 15:12:12 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 879a77ed88 to 4b0b1dd41a 2022-09-08 15:57:43 +00:00 Compare
frederick commented 2022-09-08 16:05:19 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1800-feature-improve-checkbox--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1800-feature-improve-checkbox--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/improve-checkbox from 4b0b1dd41a to 73bfd43560 2022-09-08 17:28:28 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 73bfd43560 to 599843452f 2022-09-08 17:56:29 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 599843452f to 536c08ac3e 2023-03-07 17:00:10 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 536c08ac3e to 8e5ea521ea 2023-03-07 18:12:21 +00:00 Compare
dpschen changed title from WIP: improved checkbox to feat: improved checkbox 2023-03-07 18:15:16 +00:00
dpschen requested review from konrad 2023-03-07 18:15:21 +00:00
konrad was assigned by dpschen 2023-03-07 18:15:27 +00:00
dpschen added the
changes requested
area/internal-code
 labels 2023-03-07 18:15:30 +00:00
konrad commented 2023-03-07 21:22:17 +00:00
Owner
Copy Link

Tests are still failing, probably related to changed selectors.

Tests are still failing, probably related to changed selectors.
👍 1
konrad reviewed 2023-03-07 21:25:59 +00:00
src/components/input/fancycheckbox.vue Outdated
@ -22,3 +18,3 @@
<script setup lang="ts">
import {ref, toRef, watch} from 'vue'
import CheckboxImg from '@/assets/checkbox.svg?component'
konrad commented 2023-03-07 21:24:29 +00:00
Owner

Nit-picking, but can we call this something other than "Img"? That makes me thing of a css-sprite png image from 2000...

Nit-picking, but can we call this something other than "Img"? That makes me thing of a css-sprite png image from 2000...
dpschen commented 2023-03-22 15:46:33 +00:00
Author
Member

Done!

Done!
dpschen marked this conversation as resolved
src/views/list/ListGantt.vue Outdated
@ -23,3 +23,3 @@
</div>
</div>
<fancycheckbox class="is-block" v-model="filters.showTasksWithoutDates">
<fancycheckbox is-block v-model="filters.showTasksWithoutDates">
konrad commented 2023-03-07 21:25:55 +00:00
Owner

Doesn't the is-block attribute require a value?

Doesn't the `is-block` attribute require a value?
dpschen commented 2023-03-10 14:13:10 +00:00
Author
Member

AFAIK is-block and :is-block="true" are identical. See https://vuejs.org/guide/components/props.html#prop-passing-details

AFAIK `is-block` and `:is-block="true"` are identical. See https://vuejs.org/guide/components/props.html#prop-passing-details
👍 1
dpschen marked this conversation as resolved
dpschen force-pushed feature/improve-checkbox from 8e5ea521ea to 3f3d2c2517 2023-03-22 15:46:28 +00:00 Compare
konrad reviewed 2023-03-23 20:58:08 +00:00
konrad left a comment
Owner

Looks good now, but tests are still failing.

Looks good now, but tests are still failing.
👍 1
dpschen force-pushed feature/improve-checkbox from 3f3d2c2517 to 893c009201 2023-03-28 11:13:55 +00:00 Compare
dpschen force-pushed feature/improve-checkbox from 893c009201 to e5b9fa6c61 2023-03-28 11:14:18 +00:00 Compare
dpschen commented 2023-03-28 11:18:48 +00:00
Author
Member
Copy Link

I had to undo #3176 because it made the now nested lable unclickable.

As a rule of thumb interactive elements should never be nested. This is especially true for interactive elements (<a> and <label> in this case).

In order to fix that issue we should rebase #3180 instead

I had to undo https://kolaente.dev/vikunja/frontend/pulls/3176 because it made the now nested lable unclickable. As a rule of thumb interactive elements should never be nested. This is especially true for interactive elements (`<a>` and `<label>` in this case). In order to fix that issue we should rebase https://kolaente.dev/vikunja/frontend/pulls/3180 instead
konrad commented 2023-03-28 11:40:54 +00:00
Owner
Copy Link

Sadly, it looks like the checkbox doesn't work anymore:

image

Sadly, it looks like the checkbox doesn't work anymore: ![image](/attachments/16dcaf27-ae73-4630-ae3e-ad0487cfa0b5)
image.png
1.8 KiB
konrad commented 2023-03-28 11:41:18 +00:00
Owner
Copy Link

In order to fix that issue we should rebase #3180 instead

You mean merge #3180 first and then rebase this PR on it?

> In order to fix that issue we should rebase #3180 instead You mean merge #3180 first and then rebase this PR on it?
dpschen commented 2023-03-28 13:21:41 +00:00
Author
Member
Copy Link

Sadly, it looks like the checkbox doesn't work anymore:

image

When did this appear (can't reproduce).

You mean merge #3180 first and then rebase this PR on it?

No

> Sadly, it looks like the checkbox doesn't work anymore: > > ![image](/attachments/16dcaf27-ae73-4630-ae3e-ad0487cfa0b5) When did this appear (can't reproduce). > You mean merge #3180 first and then rebase this PR on it? No
konrad commented 2023-03-28 15:31:03 +00:00
Owner
Copy Link

When did this appear (can't reproduce).

I marked a task done and expected the checkbox to show that accordingly

> When did this appear (can't reproduce). I marked a task done and expected the checkbox to show that accordingly
dpschen commented 2023-03-28 17:03:05 +00:00
Author
Member
Copy Link

When did this appear (can't reproduce).

I marked a task done and expected the checkbox to show that accordingly

For me everything works in the linked preview branch.
In case you tested locally you might have had an outdated branch, because this issue was existent without the last commit

> > When did this appear (can't reproduce). > > I marked a task done and expected the checkbox to show that accordingly For me everything works in the linked preview branch. In case you tested locally you might have had an outdated branch, because this issue was existent without the last commit
konrad commented 2023-03-28 18:20:42 +00:00
Owner
Copy Link

Looks like it works fine in Chrome, but not in Firefox.

Looks like it works fine in Chrome, but not in Firefox.
👍 1
dpschen commented 2023-03-28 20:32:39 +00:00
Author
Member
Copy Link

Looks like it works fine in Chrome, but not in Firefox.

Seems like FF doesn't support the has selector yet… The polyfill needs to be activated. I tried a bit but couldn't get it running yet.

> Looks like it works fine in Chrome, but not in Firefox. Seems like FF doesn't support the has selector yet… The polyfill needs to be activated. I tried a bit but couldn't get it running yet.
dpschen force-pushed feature/improve-checkbox from e5b9fa6c61 to 4703f9c4d5 2023-03-29 15:22:19 +00:00 Compare
dpschen commented 2023-03-29 15:23:12 +00:00
Author
Member
Copy Link

@konrad should work now!

@konrad should work now!
konrad approved these changes 2023-03-29 15:26:50 +00:00
konrad left a comment
Owner

Looks good now!

Looks good now!
🎉 1 🚀 1
konrad scheduled this pull request to auto merge when all checks succeed 2023-03-29 15:27:07 +00:00
konrad merged commit 4703f9c4d5 into main 2023-03-29 15:30:24 +00:00
dpschen commented 2023-03-29 15:56:52 +00:00
Author
Member
Copy Link

Looks good now!

Finally Yiehaa

> Looks good now! Finally Yiehaa
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#1812 feature/feat-improve-ts-setup
vikunja/frontend
Reference: vikunja/frontend#1800
No description provided.
Delete Branch "dpschen/frontend:feature/improve-checkbox"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?