WIP: feat: improve vite-plugin-pwa setup #1813

dpschen · 2022-04-11T21:57:46Z

dpschen commented

2022-04-11 21:57:46 +00:00

I tried to follow the documentation of vite-plugin-pwa

dpschen added 1 commit 2022-04-11 21:57:47 +00:00

continuous-integration/drone/pr Build is failing Details

7d7c44069c

feat: improve vite-plugin-pwa setup

konrad reviewed 2022-04-18 17:23:55 +00:00

package.json

						
				@ -80,6 +81,7 @@

				    "eslint-plugin-vue": "8.6.0",

				    "express": "4.17.3",

				    "happy-dom": "2.55.0",

				    "https-localhost": "^4.7.1",

konrad commented

2022-04-18 17:22:39 +00:00

What is this used for?

dpschen commented

2022-04-18 18:52:59 +00:00

See: https://vite-plugin-pwa.netlify.app/guide/testing.html#testing-service-worker-over-https

src/components/home/update.vue

						
				@ -48,0 +14,4 @@

				/**

				 * start

konrad commented

2022-04-18 17:23:27 +00:00

hmmm this comment seems quite redundant to me.

👍 1

dpschen commented

2022-04-18 18:56:44 +00:00

Agreed. This is also not finished. Was mostly sharing in the sense of:

hey, I checked out the documentation of vite-plugin-pwa, saw some stuff that is interesting, played around with it and wanted it to share in case this is interesting.

Agreed. This is also not finished. Was mostly sharing in the sense of: > hey, I checked out the documentation of vite-plugin-pwa, saw some stuff that is interesting, played around with it and wanted it to share in case this is interesting.

😆 1