feat: task relatedTasks script setup #1939

Merged
konrad merged 3 commits from dpschen/frontend:feature/feature-task-related-tasks-script-setup into main 2022-09-21 18:22:31 +00:00
Member
No description provided.
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1939-feature-feature-task-related-tas--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1939-feature-feature-task-related-tas--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad requested changes 2022-05-14 14:40:41 +00:00
konrad left a comment
Owner

A few things I noticed:

  1. When searching and selecting a new related task from the list you get this error message:

image

  1. Adding a related task does not show its title in the list:

image

  1. After removing a related task the task itself disappears but the headline stays:

image

A few things I noticed: 1. When searching and selecting a new related task from the list you get this error message: ![image](/attachments/f09bf0a4-f479-42ec-bd22-9805578aa646) 2. Adding a related task does not show its title in the list: ![image](/attachments/074c230b-bc4f-404e-bec3-1a81b0d32a9b) 3. After removing a related task the task itself disappears but the headline stays: ![image](/attachments/aad078aa-43df-4630-88f4-e1a4af98962b)
2.6 KiB
9.1 KiB
6.3 KiB
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 6c36f26dac to e5881939ed 2022-05-19 20:16:30 +00:00 Compare
Author
Member

I couldn't reproduce (1) but the title does indeed not show up. Will check…

I couldn't reproduce (1) but the title does indeed not show up. Will check…
dpschen closed this pull request 2022-05-19 20:37:51 +00:00
dpschen reopened this pull request 2022-05-19 20:37:54 +00:00
Author
Member

closed by accident… I think I was #mausgerutscht

closed by accident… I think I was #mausgerutscht
dpschen force-pushed feature/feature-task-related-tasks-script-setup from e5881939ed to 591ee33ed9 2022-05-20 22:15:31 +00:00 Compare
Owner

2 and 3 seem to still be a problem.

2 and 3 seem to still be a problem.
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 591ee33ed9 to 9e862ca444 2022-08-05 18:53:31 +00:00 Compare
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 9e862ca444 to 4083c087d2 2022-08-05 20:14:49 +00:00 Compare
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 4083c087d2 to 2402c6f6dd 2022-09-15 17:48:40 +00:00 Compare
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 2402c6f6dd to 08dc289260 2022-09-15 20:42:04 +00:00 Compare
dpschen requested review from konrad 2022-09-20 15:39:02 +00:00
konrad requested changes 2022-09-21 14:17:33 +00:00
@ -319,0 +336,4 @@
async function createAndRelateTask(title: string) {
const newTask = await taskService.create(new TaskModel({title, listId: props.listId}))
console.log('new task created', JSON.parse(JSON.stringify(newTask)))

Can you remove this console.log?

Can you remove this `console.log`?
Author
Member

Done!

Done!
dpschen marked this conversation as resolved
dpschen requested review from konrad 2022-09-21 14:28:46 +00:00
Owner

Please resolve the conflicts, should be ready to merge once CI passes.

Please resolve the conflicts, should be ready to merge once CI passes.
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 4ea2bbc3da to 8d69acc9af 2022-09-21 16:24:52 +00:00 Compare
dpschen force-pushed feature/feature-task-related-tasks-script-setup from 8d69acc9af to 43e2d036d7 2022-09-21 16:36:51 +00:00 Compare
konrad approved these changes 2022-09-21 18:22:20 +00:00
konrad merged commit d57e27b4a6 into main 2022-09-21 18:22:31 +00:00
konrad deleted branch feature/feature-task-related-tasks-script-setup 2022-09-21 18:22:31 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.