vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: list settings edit script setup #1988

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-list-settings-edit-script-setup into main 2022-09-02 15:13:33 +00:00
Conversation 5 Commits 1 Files Changed 3 +78 -44
dpschen commented 2022-05-21 15:29:57 +00:00
Member
Copy Link
No description provided.
konrad reviewed 2022-05-22 14:26:48 +00:00
src/views/list/settings/edit.vue Outdated
@ -113,0 +99,4 @@
watch(
() => route.params.listId,
async () => {
// loadList
konrad commented 2022-05-22 14:26:48 +00:00
Owner

I think this can be removed?

I think this can be removed?
dpschen commented 2022-05-22 14:37:02 +00:00
Author
Member

Yes it can. It was thought as a comment to explain what happens, because I removed the original function that was triggered by the watcher. Should I remove it / adjust casing?

Yes it can. It was thought as a comment to explain what happens, because I removed the original function that was triggered by the watcher. Should I remove it / adjust casing?
konrad commented 2022-05-22 14:43:04 +00:00
Owner

Should I remove it

Please do. Looks a bit lost right now.

> Should I remove it Please do. Looks a bit lost right now.
👍 1
dpschen commented 2022-05-22 14:45:37 +00:00
Author
Member

Removed

Removed
dpschen marked this conversation as resolved
frederick commented 2022-05-22 14:38:48 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1988-feature-feat-list-settings-edit---vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1988-feature-feat-list-settings-edit---vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/feat-list-settings-edit-script-setup from ebf7d3ca0c to d9556be2f9 2022-05-22 14:45:30 +00:00 Compare
konrad requested changes 2022-05-22 20:47:46 +00:00
konrad left a comment
Owner

Looks like the list data is not properly populated:

image

("another list with background" is the currently opened list, not the one I tried to edit)

There's a relevant error in the console which is probably the cause of that:

image

Looks like the list data is not properly populated: ![image](/attachments/2e21d8b3-89f5-4d66-b6fb-834c0eb49d44) ("another list with background" is the currently opened list, not the one I tried to edit) There's a relevant error in the console which is probably the cause of that: ![image](/attachments/e6924162-ab07-4634-b9d3-b09a837a2df1)
image.png
34 KiB
image.png
37 KiB
dpschen force-pushed feature/feat-list-settings-edit-script-setup from d9556be2f9 to 1f566b6fdb 2022-05-22 22:33:43 +00:00 Compare
dpschen force-pushed feature/feat-list-settings-edit-script-setup from 1f566b6fdb to dbe35700c1 2022-06-21 22:43:12 +00:00 Compare
konrad commented 2022-07-04 15:54:53 +00:00
Owner
Copy Link

Now the form is not populated at all:

image

There's this error in the console:

image

Now the form is not populated at all: ![image](/attachments/85e4f1ca-a96f-421a-bb52-2ce2ab126c69) There's this error in the console: ![image](/attachments/4e4bfcef-372e-4dc2-b709-c07eb1caf3bf)
image.png
21 KiB
image.png
103 KiB
dpschen changed title from feat: list settings edit script setup to WIP: feat: list settings edit script setup 2022-07-04 22:01:57 +00:00
dpschen force-pushed feature/feat-list-settings-edit-script-setup from dbe35700c1 to 351539d70f 2022-07-06 21:09:51 +00:00 Compare
dpschen force-pushed feature/feat-list-settings-edit-script-setup from 351539d70f to 668a42e9d8 2022-07-10 11:28:32 +00:00 Compare
dpschen changed title from WIP: feat: list settings edit script setup to feat: list settings edit script setup 2022-07-10 11:29:43 +00:00
dpschen commented 2022-07-10 11:29:57 +00:00
Author
Member
Copy Link

Should be fixed.
I moved the list loading logic outside in a useList composable.
By doing this we can use that logic easily in other components.

Should be fixed. I moved the list loading logic outside in a useList composable. By doing this we can use that logic easily in other components.
dpschen requested review from konrad 2022-07-10 11:30:05 +00:00
konrad was assigned by dpschen 2022-07-10 11:32:35 +00:00
konrad commented 2022-07-11 10:11:31 +00:00
Owner
Copy Link

When I try to save the settings I get this error:

image

When I try to save the settings I get this error: ![image](/attachments/dded29a8-3082-41b9-9b64-a9763656bdd4)
image.png
32 KiB
dpschen force-pushed feature/feat-list-settings-edit-script-setup from 668a42e9d8 to a1b646cbf4 2022-08-18 16:57:31 +00:00 Compare
konrad commented 2022-09-02 15:12:32 +00:00
Owner
Copy Link

The "this will remove xx tasks" when removing a list does not seem to work anymore (it just spins). Removing a list works though.

image

I'm not sure if this was broken in this PR but it looks like removing does not work at all in the current main branch so I wouldn't say this is a blocker to merging this PR.

The "this will remove xx tasks" when removing a list does not seem to work anymore (it just spins). Removing a list works though. ![image](/attachments/484cb428-bab6-4855-85f9-575a4d8797b8) I'm not sure if this was broken in this PR but it looks like removing does not work at all in the current main branch so I wouldn't say this is a blocker to merging this PR.
image.png
15 KiB
konrad approved these changes 2022-09-02 15:13:16 +00:00
konrad merged commit f6437c81da into main 2022-09-02 15:13:33 +00:00
konrad deleted branch feature/feat-list-settings-edit-script-setup 2022-09-02 15:13:33 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1988
No description provided.
Delete Branch "dpschen/frontend:feature/feat-list-settings-edit-script-setup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?