vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: only warn once if triggeredNotifications are not supported #2344

Merged
konrad merged 1 commits from dpschen/frontend:feature/fix-triggered-notifications-warning into main 2022-09-14 12:45:22 +00:00
Conversation 4 Commits 1 Files Changed 1 +5 -3
dpschen commented 2022-09-09 12:31:35 +00:00
Member
Copy Link

NOTE: Since they are deprecated they shouldn't be supported anywhere anymore. The target of this pull-request is to clean the console logging clean

NOTE: Since they are deprecated they shouldn't be supported anywhere anymore. The target of this pull-request is to clean the console logging clean
dpschen added 1 commit 2022-09-09 12:31:36 +00:00
continuous-integration/drone/pr Build is passing Details
6cf32f4eb2
fix: only warn once if triggeredNotifications are not supported 
NOTE: Since they are deprecated they shouldn't be supported anywhere anymore. The target of this pull-request is to clean the console logging clean
konrad commented 2022-09-13 12:59:19 +00:00
Owner
Copy Link

I think we can just remove the triggered notifications alltogether since the chrome feature will be removed anyway and we have an app now which can properly trigger notifications.

I think we can just remove the triggered notifications alltogether since the chrome feature will be removed anyway and we have an app now which can properly trigger notifications.
frederick commented 2022-09-13 17:27:06 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2344-feature-fix-triggered-notificati--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2344-feature-fix-triggered-notificati--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2022-09-14 11:42:33 +00:00
Author
Member
Copy Link

I think we can just remove the triggered notifications alltogether since the chrome feature will be removed anyway and we have an app now which can properly trigger notifications.

Agree. This pull-request was as written in the description more a quick fix to remove too many warnings. Makes it easier to follow in Sentry.

I think I would not be able to remove the feature completely since I'm not sure if I would catch all of the affected areas in the code.

> I think we can just remove the triggered notifications alltogether since the chrome feature will be removed anyway and we have an app now which can properly trigger notifications. Agree. This pull-request was as written in the description more a quick fix to remove too many warnings. Makes it easier to follow in Sentry. I think I would not be able to remove the feature completely since I'm not sure if I would catch all of the affected areas in the code.
konrad was assigned by dpschen 2022-09-14 11:42:41 +00:00
dpschen requested review from konrad 2022-09-14 11:42:48 +00:00
konrad commented 2022-09-14 12:44:50 +00:00
Owner
Copy Link

Okay then lets merge this and remove the triggered notifications in another PR.

Okay then lets merge this and remove the triggered notifications in another PR.
konrad approved these changes 2022-09-14 12:45:12 +00:00
konrad merged commit f083f181e2 into main 2022-09-14 12:45:22 +00:00
konrad deleted branch feature/fix-triggered-notifications-warning 2022-09-14 12:45:22 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2344
No description provided.
Delete Branch "dpschen/frontend:feature/fix-triggered-notifications-warning"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?