feat: feat-attachments-script-setup #2358

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-attachments-script-setup into main 2022-09-22 15:31:15 +00:00
Member
No description provided.
dpschen force-pushed feature/feat-attachments-script-setup from 4463eef23f to e02d498ccc 2022-09-15 09:24:11 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2358-feature-feat-attachments-script---vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2358-feature-feat-attachments-script---vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen requested review from konrad 2022-09-15 09:33:20 +00:00
konrad was assigned by dpschen 2022-09-15 09:33:24 +00:00
dpschen changed title from WIP: feat: feat-attachments-script-setup to feat: feat-attachments-script-setup 2022-09-15 09:33:29 +00:00
konrad requested changes 2022-09-15 10:10:02 +00:00
konrad left a comment
Owner

When I click on the attachments button on the right I get this error:

image

When I click on the attachments button on the right I get this error: ![image](/attachments/c785fc2b-ea87-4735-a3df-e787b3f0ee7c)
konrad removed their assignment 2022-09-15 11:36:26 +00:00
dpschen was assigned by konrad 2022-09-15 11:36:26 +00:00
dpschen force-pushed feature/feat-attachments-script-setup from e02d498ccc to 21fc4f462d 2022-09-15 22:16:01 +00:00 Compare
dpschen force-pushed feature/feat-attachments-script-setup from 21fc4f462d to 18cd8670f4 2022-09-15 22:17:46 +00:00 Compare
Owner

Now there is this when opening a task with an attachment:

Uncaught (in promise) TypeError: can't convert symbol to string
Now there is this when opening a task with an attachment: ``` Uncaught (in promise) TypeError: can't convert symbol to string ```
dpschen requested review from konrad 2022-09-21 19:49:18 +00:00
Owner

Looks almost perfect, but the attachment is now a link:

image

vs on current master:

image

Looks almost perfect, but the attachment is now a link: ![image](/attachments/a2813f45-27d2-4960-9c29-e8d15145fed7) vs on current master: ![image](/attachments/ad8b2443-7ff2-47d2-8a71-f62572217ecc)
Owner

It looks like attachments uploaded via drag and drop will now be added multiple times.

It looks like attachments uploaded via drag and drop will now be added multiple times.
dpschen force-pushed feature/feat-attachments-script-setup from d58ea71ef5 to f5c1d40c67 2022-09-21 22:30:22 +00:00 Compare
Author
Member

Do you mean: 'can be added muliple times'?
In the sense that you can add the same attachment more than once.

Because I just checked this out again and that is the only thing that I could do in that regard.

Also in the latest version I cannot reproduce the blue url color.

Do you mean: 'can be added muliple times'? In the sense that you can add the same attachment more than once. Because I just checked this out again and that is the only thing that I could do in that regard. Also in the latest version I cannot reproduce the blue url color.
Owner

Do you mean: 'can be added muliple times'?
In the sense that you can add the same attachment more than once.

No, when I drag a file once it is uploaded multiple times.

> Do you mean: 'can be added muliple times'? In the sense that you can add the same attachment more than once. No, when I drag a file once it is uploaded multiple times.
Owner

Also in the latest version I cannot reproduce the blue url color.

jup that seems fixed.

> Also in the latest version I cannot reproduce the blue url color. jup that seems fixed.
Owner

Do you mean: 'can be added muliple times'?
In the sense that you can add the same attachment more than once.

No, when I drag a file once it is uploaded multiple times.

This seems to work now too.

> > Do you mean: 'can be added muliple times'? > In the sense that you can add the same attachment more than once. > > No, when I drag a file once it is uploaded multiple times. This seems to work now too.
konrad approved these changes 2022-09-22 15:31:02 +00:00
konrad merged commit 4dfcd8e70f into main 2022-09-22 15:31:15 +00:00
konrad deleted branch feature/feat-attachments-script-setup 2022-09-22 15:31:15 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.