feat: port label store to pinia | pinia 1/9 #2391
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#2391
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/feat-pinia-label-store"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
6d6a2f661c
to216d931c53
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://2391-feature-feat-pinia-label-store--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
WIP: feat: port label store to piniato feat: port label store to piniafeat: port label store to piniato feat: port label store to pinia | pinia 1/9@ -310,2 +312,3 @@
foundLabels() {
return this.$store.getters['labels/filterLabelsByQuery'](this.labels, this.query)
const labelStore = useLabelStore()
Shouldn't this use the setup function? (not
script setup
).We could introduce a setup block in this component.
But since this pull request was only about having the fastest way to integrate the store I didn't see that necessary.
Setup would only require the additional import of
computed
. Plus we would need to export it again from that function.So overall more complex then this quick fix here.
Makes sense, especially considering this would be redundant once we'll have everything migrated over to
script setup
.Exactly :)