vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

WIP: feat: vibrate on marked as done #2665

Closed
dpschen wants to merge 1 commits from dpschen/frontend:feature/vibrate-on-marked-as-done into main
pull from: dpschen/frontend:feature/vibrate-on-marked-as-done
merge into: vikunja:main
Conversation 4 Commits 1 Files Changed 1 +7
dpschen commented 2022-11-09 22:18:42 +00:00
Member
Copy Link

I couldn't test this, since the battery of my online android was emtpy…
Doesn't work on iOS, but it's a nice progressive enhancement.
Should be really subtle though, which I can't test. Maybe 100ms is already to long and it should be 40 or something like that.

I do know that this can have a different feeling on different phones, so might also help to test on more than one device.

We should move this to the store later together with the method itself.
For now I just wanted this to be implemented somewhere as a nice quick-win.

I couldn't test this, since the battery of my online android was emtpy… Doesn't work on iOS, but it's a nice progressive enhancement. Should be really subtle though, which I can't test. Maybe 100ms is already to long and it should be 40 or something like that. I do know that this can have a different feeling on different phones, so might also help to test on more than one device. We should move this to the store later together with the method itself. For now I just wanted this to be implemented somewhere as a nice quick-win.
dpschen added the
kind/feature
 label 2022-11-09 22:18:42 +00:00
konrad was assigned by dpschen 2022-11-09 22:18:42 +00:00
dpschen requested review from konrad 2022-11-09 22:18:48 +00:00
frederick commented 2022-11-09 22:23:38 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2665-feature-vibrate-on-marked-as-don--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2665-feature-vibrate-on-marked-as-don--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2022-11-10 07:23:37 +00:00
Owner
Copy Link

Does not seem to work on my phone :/ maybe it needs to ask for permission first?

This should be configurable, there will certainly be people who don't want this.

Does not seem to work on my phone :/ maybe it needs to ask for permission first? This should be configurable, there will certainly be people who don't want this.
dpschen commented 2022-11-10 07:33:53 +00:00
Author
Member
Copy Link

Does not seem to work on my phone :/ maybe it needs to ask for permission first?

This should be configurable, there will certainly be people who don't want this.

Ohh okay? The last time I used this no permission was necessary. Seems like they changed that.

For the configuration we should probably wait until we can save this kind of dtuff on the server.

> Does not seem to work on my phone :/ maybe it needs to ask for permission first? > > This should be configurable, there will certainly be people who don't want this. Ohh okay? The last time I used this no permission was necessary. Seems like they changed that. For the configuration we should probably wait until we can save this kind of dtuff on the server.
👍 1
dpschen changed title from feat: vibrate on marked as done to WIP: feat: vibrate on marked as done 2022-11-10 07:34:38 +00:00
dpschen force-pushed feature/vibrate-on-marked-as-done from f000648afc to e5b257aa43 2022-11-10 15:07:28 +00:00 Compare
dpschen commented 2023-04-11 22:21:02 +00:00
Author
Member
Copy Link

Closing this. Might redo but then better.

Closing this. Might redo but then better.
dpschen closed this pull request 2023-04-11 22:21:02 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2665
No description provided.
Delete Branch "dpschen/frontend:feature/vibrate-on-marked-as-done"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?