feat: add histoire #2724
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#2724
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/add-histoire"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fb4f2ce92b
toda05a34a2a
da05a34a2a
to229de995d9
229de995d9
to7fda4a4a08
WIP: feat: add histoireto feat: add histoireHi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://2724-feature-add-histoire--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
@ -0,0 +9,4 @@
app.use(createRouter({
history: createMemoryHistory(),
routes: [
{ path: '/', name: 'home', component: { render: () => null } },
Do we need this in every story?
Only where wewant to use the router. It can also be done in the global setup. I didn't want to do this so that we also have the option to test components without router. Could be abstracted into a function if we want to reuse it in other component stories later. But as of now it's only used here.
Yeah makes sense. Let's keep it like this for now and abstract it out if needed in more than one place.
To be clear: we create here mock targets for the router.
I wasn't able to run histore:
Not sure what the problem is?
The
.histoire
folder should be ignored by gitignore as well.Maybe because of this:
b11afe0aa4
Done
Looks like it still does not work for me :/
23c9edfa9c
to58dc20f4a8
I added
.direnv
tostoryIgnored
. Does that solve it for you?Seems to work now. Thanks for fixing!
Please rebase once more, ready to merge then.
Oh no! I didn't even want to re-request approval.
That button doesn't look like a button, but more like a state (and directly next to it you access the CI logs).