redirect to oidc provider if configured correctly #2805

viehlieb · 2022-12-08T14:36:23Z

viehlieb commented

2022-12-08 14:36:23 +00:00

redirects to oidc provider on logout if configured.

Pls refer to config.yml.sample and above mentioned PR

Counterpart to https://kolaente.dev/vikunja/api/pulls/1340 redirects to oidc provider on logout if configured. Pls refer to config.yml.sample and above mentioned PR

viehlieb added 1 commit 2022-12-08 14:36:25 +00:00

continuous-integration/drone/pr Build is passing Details

f5c31bd209 redirect to oidc provider if configured correctly

frederick commented

2022-12-08 14:40:02 +00:00

Hi viehlieb!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2805-feature-redirecttooidclogouturlo--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi viehlieb! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2805-feature-redirecttooidclogouturlo--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

viehlieb referenced this pull request from vikunja/vikunja

2022-12-08 14:52:34 +00:00

feature/redirect_to_oidc_logout_url_on_logout #1340

konrad requested changes 2022-12-08 15:41:22 +00:00

src/helpers/redirectToProvider.ts Outdated

						
				@ -18,2 +18,4 @@

					window.location.href = `${provider.authUrl}?client_id=${provider.clientId}&redirect_uri=${redirectUrl}${provider.key}&response_type=code&scope=openid email profile&state=${state}`

				}

				export const redirectToProviderOnLogout = (provider: IProvider) => {

					if (provider.logoutUrl.length > 0) window.location.href = `${provider.logoutUrl}`

konrad commented

2022-12-08 15:40:04 +00:00

Please make this explicit:

	if (provider.logoutUrl.length > 0) {
    	window.location.href = `${provider.logoutUrl}`
    }

Please make this explicit: ```js if (provider.logoutUrl.length > 0) { window.location.href = `${provider.logoutUrl}` } ```

konrad commented

2022-12-08 15:42:03 +00:00

We could make this more complicated and only redirect users who have an account on the openid provider which has a logout url configured, but it's fine as you implemented it.

viehlieb added 1 commit 2022-12-23 13:53:17 +00:00